Surface chat stream errors#6
Open
clyons wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Big Picture
When chat streaming fails after the HTTP connection has already opened, users should get an actionable error instead of a silent stop or generic stream failure. This change keeps the existing streaming protocol intact, but adds one explicit error path: backend chat exceptions are converted into Server-Sent Event
errormessages, and the frontend client routes those messages through its existingonErrorcallback.The goal is to make setup and provider failures easier to diagnose without changing chat behavior when the provider succeeds. This is intentionally independent of provider selection work: it does not add OpenAI support, change Anthropic defaults, or modify how chat responses are generated.
Summary
event: errorand then[DONE]backend/.enverrorevents so existing UI error handling can show the messageNotes
backend/routers/chat.pyandfrontend/src/api/client.ts.status, default message, and[DONE]events.Validation
cd backend && python3 -m py_compile main.py services/*.py routers/*.pymake fe-build8765with an intentionally invalid Anthropic key;/api/chatreturned:streamChatsmoke script confirmed an SSEerrorevent reaches theonErrorcallback.