Change Field to TextField#40
Closed
Diegovsky wants to merge 2 commits into
Closed
Conversation
|
models.CharField is likely a better field type to use moving forward. But thanks for providing this. |
|
Can we merge this change ? @ericls @Diegovsky |
Merged
Owner
|
merged in #41 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to use
HashidsFieldwith DRF and django-spectacular (DS) (an OpenAPI schema generator for DRF), I got errors which accusedHashidsFieldof not mapping correctly into any specific OpenAPI type.This stems from the fact that
HashidsField, while for all intents and purposes acts like astr, does not have a way to tell this to DS. A simple fix would be to makeHashidsFieldinherit fromTextFieldinstead ofField. I believe this is correct but I'm open to feedback.I'm not familiar enough with the django ecosystem to understand how to run the tests from this repo, but at a first glance, basic queries worked flawlessly in my project.