Sef implementation #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-bocioroaga
requested changes
Aug 20, 2025
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "eric-oss-hello-world-python-app.name" . }}-envoy-template |
Contributor
There was a problem hiding this comment.
name: {{ include "eric-oss-hello-world-python-app.name" . }}-envoy-template
change to
name: {{ include "eric-oss-hello-world-python-app.name" . }}-envoy-configmap
to conform with rApp naming convention for k8s resources
Contributor
There was a problem hiding this comment.
we may also consider renaming envoy to a generic proxy to signal the intent of the configmap better
| secret: | ||
| secretName: {{ include "eric-oss-hello-world-python-app.clientSecret" . | quote }} | ||
| defaultMode: 420 | ||
| - name: envoy-platform-cacerts |
Contributor
There was a problem hiding this comment.
should we mention envoy at all regarding secrets? certs are not locked to a specific proxy vendor, other rApp developers may choose to use alternatives like Nginx and these certs would still work fine for that
| ports: | ||
| - port: {{ .Values.service.port }} | ||
| targetPort: 8050 | ||
| - port: {{ .Values.service.httpport }} |
| protocol: TCP | ||
| name: http | ||
| name: envoy-http | ||
| - port: {{ .Values.service.httpsport }} |
| clientCredsMountPath: "/etc/client-creds/" | ||
| envoyPlatformCaCertMountPath: "/etc/certs/ca" | ||
| envoyAppCertMountPath: "/etc/certs/app" | ||
| #envoyPlatformCaCertFileName: "dummy1.crt" |
Contributor
There was a problem hiding this comment.
leftover comments? should these be deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.