Widen installation_history version columns to nvarchar(512) (#712)#722
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 26, 2026
Merged
Widen installation_history version columns to nvarchar(512) (#712)#722erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
@@Version can exceed 255 characters on some SQL Server editions. This caused installation_history inserts to fail, making the installer think it was always a fresh install. - Fresh installs: column defined as nvarchar(512) - Upgrades: ALTER COLUMN in 2.4.0-to-2.5.0 upgrade script - Idempotent: checks current max_length before altering Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@@Version can exceed 255 chars. Fixes install detection failing on long version strings. Upgrade script for existing installs, idempotent.