Feature/query store waitstats#136
Closed
rferraton wants to merge 10 commits intoerikdarlingdata:mainfrom
Closed
Conversation
…e-link-text Shorten update link text
…ngdata-patch-1 Delete .coderabbit.yaml
- Increase metric label font size from 9 to 12 for readability - Use ForegroundBrush instead of muted SlicerLabelBrush for metric label - Fix metric label showing "Total" for avg metrics (e.g., avg-cpu showed "Total CPU" instead of "Avg CPU") by splitting combined or-patterns - Add per-bucket average properties to QueryStoreTimeSlice so the slicer chart shape reflects the selected metric (total vs avg) instead of always showing totals Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…r-metric-label Fix Query Store time slicer metric display
…ait profile with v/% toggle, resizable separator with chevron, ribbon click/double-click interactions
- display simple stacked wait profile per default instead on %stacked
Most Debug.WriteLine statements for wait stats have been removed, leaving only exception logging. The WaitProfile column visibility toggle now uses SortMemberPath instead of a hardcoded index, making the code more robust to column order changes.
Wrapped denominator in NULLIF to avoid division by zero errors when calculating wait_ratio in QueryStoreService.cs. Also made minor formatting and comment improvements for clarity.
Contributor
Author
|
Sorry i was distracted and push to main instead dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Main feature
Add informations about wait stats stored in the query store for :
New metric
The metric Wait Time Ratio (WTR) is used but the definition vary a little bit depending on the level of detail you look at :
So this can be a little bit confusing, but i think it is a good compromise and should works well for production databases.
==> The debates are open !)
==> i have not added tooltips for that : i need to have a little reflexion on where to put the help tooltips to avoid surcharge
Features :
Which component(s) does this affect?
How was this tested?
Fix compare last PR
I didn't follow suggestion about WaitRatioText and string-formatted percentages will sort lexicographically because i think (and test) and it seams the sort is correct.
Checklist
dotnet build -c Debug)dotnet test)