Fix/querystore improvment and fixes 202603#148
Merged
erikdarlingdata merged 4 commits intoerikdarlingdata:devfrom Mar 26, 2026
Merged
Conversation
… plan grid and try improve performance of querystore grid fetch
FetchPlanWaitStatsAsync now accepts an optional planIds parameter. When provided, the method creates a temp table and filters results to only those plan IDs for efficient querying. SQL construction and connection logic were refactored to support this feature.
… cause grid query crash
erikdarlingdata
approved these changes
Mar 26, 2026
Owner
erikdarlingdata
left a comment
erikdarlingdata
left a comment
There was a problem hiding this comment.
Looks good — fixes a real bug in the phase 4 ORDER BY (alias mismatch from #145), plus the wait stats split, progress bars, and handle hit zones from #146 done cleanly on top of current dev.
Minor nits for follow-up:
globalWaitTaskassigned but never awaited (line 191) — should be_ = FetchGlobalWaitStatsOnlyAsync(...)for fire-and-forget clarity- Debug.WriteLines still in catch blocks
orderClausealias stripping (ps.→ bare) is unnecessary but harmless
None blocking. Thanks @rferraton!
erikdarlingdata
added a commit
that referenced
this pull request
Mar 26, 2026
- Fix fire-and-forget: globalWaitTask variable replaced with _ = discard - Remove Debug.WriteLines from wait stats catch blocks, add separate OperationCanceledException handler for clean cancellation - Remove unused System.Diagnostics using - Restore ps. prefix on orderClause (used in ranked CTE where ps is the correct alias for #plan_stats) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Mar 26, 2026
Post-merge cleanup for PR #148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
order bycommand that use a table alias. In the optimized query that are no more relevant and cause one query to crash for the grid data fetchWhich component(s) does this affect?
How was this tested?
Describe the testing you've done. Include:
Checklist
dotnet build -c Debug)dotnet test)