feat(mcp): Phase 9 — optional overlay auth preflight - #377
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇
@erishforG MCP
tools/callpreflight now rejects explicitly requested GitHub-backed optional overlays when no delegated token is present.왜
Refs #294.
docs/mcp/spec.mddefines optional overlays such as PR/CI status as GitHub-backed behavior that should require delegated auth when requested. This keeps local-only calls working while making explicit overlay requests fail predictably.변경
tools/callarguments into MCP preflight.include_pr/include_cirequests and return the existingAUTH_REQUIREDMCP error envelope without dispatching handlers.다음 Phase 힌트
INSUFFICIENT_SCOPEcan be returned when a token lackspull_request:readorchecks:read.리스크
Low. Change is isolated to
src/mcp/dispatcher preflight plus MCP fixtures; no CLI surface or worktree core logic changes.롤백
Revert this commit to restore previous behavior where optional overlay arguments were not checked before handler dispatch.
Test plan
cargo build --quietcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test --quiet