Skip to content

Comments

Michael shooting while moving#43

Open
themehdev wants to merge 16 commits intomainfrom
michael-shooting-while-moving
Open

Michael shooting while moving#43
themehdev wants to merge 16 commits intomainfrom
michael-shooting-while-moving

Conversation

@themehdev
Copy link
Contributor

uhm idk it kinda works but not really
idk what the prob is tho, ill work on this more tomorrow

@themehdev themehdev marked this pull request as ready for review February 18, 2026 00:24
@themehdev
Copy link
Contributor Author

it works if you are not going that fast, so I reduced the max speed to 2/3 when not shooting but in alliance zone, and 1/3 when shooting

might want a trigger to remove this, or just get arid of the aiming functionality alltogeter

actually imma do that one sec

kk the aiming functionality is commented out now, but still usable in case we ever want it again

still max speed of 1/3 when shooting, might need to be changed later but max speed of even 1/5 normal is better than 0

@themehdev
Copy link
Contributor Author

also nice job anshu

@themehdev
Copy link
Contributor Author

also jsut realized that the code works exactly the same as the normal one if we set the max shooting speed to 0, so I am just going to remove the "shoot on move" variable, and add a comment to it

…tant

just need to reverse the hopper after shooting is done and I will be happy
@themehdev
Copy link
Contributor Author

#45 should eventually be fixed but idk how so yeah ill do that maybe later

all the tested positions should be in the units library and not doubles, but im too lazy to change that rn
Copy link
Contributor Author

@themehdev themehdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopper should be run backward for a bit after shooting is done, shooter constants should be updated to be distances, d-pad probably shouldnt interrupt the shoot command (but there is a chance this ends up being useful if it works how I think it will work, so maybe not), but none of these are breaking and can be done later, so id say it is good to be merged in

@themehdev themehdev requested a review from kausikbs February 20, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants