Open
Conversation
…rent builders more consistent, and enable configuration
…eader-links configurable
Author
|
Also, for a future PR, I'm looking to improve the manual builder; the current builder flattens the manual structure and breaks all relative links in the markdown (it doesn't even change |
0952cf0 to
798c2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, ESdoc has been of great use so far, but some of the html generation was not customizable enough for me. So I changed the builder system a bit:
HtmlBasePlugin, and left a proxy to it. It works the same as previously, but people can extend the Plugin class ofesdoc-publish-html-pluginnow to add their own builders.execfunction signature. Constructors can be different, but I kept the default set of builders consistent (builders are added by providing a creator-function, which wraps instantiation).DocBuilderclass in two: a base builder class namedBuilderthat's very general, andDocBuilder. The oldDocBuilderclass is way too large for my liking, it's better to layer functionality.Features:
See the new
esdoc-publish-html-pluginREADME.mdfor details about the configuration format.