Skip to content

Fix failure to unpack json to typing.* types (typing.* cannot be instantiated), fixes #1 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yannik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix failure to unpack json to typing.* types (typing.* cannot be instantiated), fixes #1 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpnet/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ def __new__(mcs, typename: str, bases, ns):
def _from_json_value(value, type_):
if type_ is type(None) and value is None:
return None
if repr(type_).startswith('typing.Union['):
if repr(type_).startswith('typing.Union[') or repr(type_).startswith('typing.Optional['):
for t in reversed(type_.__args__):
try:
return _from_json_value(value, t)
except (AttributeError, TypeError):
continue
if isinstance(type_, (type(Iterable), type(Sequence))):
if repr(type_).startswith('typing.Iterable[') or repr(type_).startswith('typing.Sequence['):
return [_from_json_value(v, type_.__args__[0]) for v in value]
if type_ is datetime and isinstance(value, str):
return dateutil.parser.parse(value)
Expand Down