Fix desktop sandbox project override sync / 修复沙箱设置项目覆盖同步#4607
Open
GTC2080 wants to merge 1 commit into
Open
Conversation
a62509d to
6a297cb
Compare
6a297cb to
50822f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasonix.tomloverrides are visible instead of being hidden by user config[tools.shell]during config rendering so the shell picker survives config round tripsRoot Cause
reasonix.tomlafter the user configSetSandboxalways saved to the user config, so changing the UI tooffcould leave a project-levelbash = "enforce"override activeCache and tool-surface notes
Verification
go test ./... -run 'TestSettingsSandboxReflectsProjectOverride|TestSetSandboxUpdatesProjectOverrideConfig'in the desktop modulego test ./internal/configgo test ./...in the desktop modulego test ./...go mod tidyin the desktop modulegofmt -l .git diff --checkFixes #4606