Skip to content

Fix desktop sandbox project override sync / 修复沙箱设置项目覆盖同步#4607

Open
GTC2080 wants to merge 1 commit into
esengine:main-v2from
GTC2080:GTC/issue-4606-sandbox-ui-sync
Open

Fix desktop sandbox project override sync / 修复沙箱设置项目覆盖同步#4607
GTC2080 wants to merge 1 commit into
esengine:main-v2from
GTC2080:GTC/issue-4606-sandbox-ui-sync

Conversation

@GTC2080

@GTC2080 GTC2080 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • read Desktop Settings sandbox values from the active workspace's effective config, so project reasonix.toml overrides are visible instead of being hidden by user config
  • save sandbox edits back to the project config when the active project already defines sandbox or shell overrides; otherwise keep the existing user-default behavior
  • persist [tools.shell] during config rendering so the shell picker survives config round trips

Root Cause

  • the desktop settings payload loaded sandbox fields from the user-level config, while runtime sessions load reasonix.toml after the user config
  • SetSandbox always saved to the user config, so changing the UI to off could leave a project-level bash = "enforce" override active

Cache and tool-surface notes

  • No provider-visible prompt, request serialization, compaction, or cache-prefix behavior changes.
  • Runtime tool behavior only changes when users edit sandbox settings in the desktop Settings panel.

Verification

  • go test ./... -run 'TestSettingsSandboxReflectsProjectOverride|TestSetSandboxUpdatesProjectOverrideConfig' in the desktop module
  • go test ./internal/config
  • go test ./... in the desktop module
  • go test ./...
  • go mod tidy in the desktop module
  • gofmt -l .
  • git diff --check

Fixes #4606

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) config Configuration & setup (internal/config) labels Jun 16, 2026
@GTC2080 GTC2080 force-pushed the GTC/issue-4606-sandbox-ui-sync branch from a62509d to 6a297cb Compare June 16, 2026 12:21
@GTC2080 GTC2080 force-pushed the GTC/issue-4606-sandbox-ui-sync branch from 6a297cb to 50822f1 Compare June 23, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sandbox模型,MCP执行报错

1 participant