fix issues with /ps flag, update /ps admin Ui#438
fix issues with /ps flag, update /ps admin Ui#438jerzean wants to merge 5 commits intoespidev:masterfrom
Conversation
updated /ps admin to use textcomponent (now has clickable commands)
src/main/java/dev/espi/protectionstones/commands/ArgAdminHelp.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/espi/protectionstones/commands/ArgAdminHelp.java
Outdated
Show resolved
Hide resolved
|
Have you pushed the changes yet? I don't see them here. |
|
not yet, cleaning up somethings, like i forgot the footer on the ps admin menu |
…ot working before with it
…ot working before with it
| // Create the hover event from the info text, add click event after | ||
| BaseComponent[] hoverComponents = TextComponent.fromLegacyText(info); | ||
| mainText.setHoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, hoverComponents)); | ||
| //toggle for running on mouse click, currently disabled |
There was a problem hiding this comment.
| //toggle for running on mouse click, currently disabled | |
| // Toggle for running on mouse click |
It is implemented here, so it isn't disabled
| <groupId>org.spigotmc</groupId> | ||
| <artifactId>spigot-api</artifactId> | ||
| <version>1.20.6-R0.1-SNAPSHOT</version> | ||
| <version>1.21.5-R0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
Do we need to bump the Spigot API version? This would make the plugin incompatible with servers still on 1.20.6-1.21.4
There was a problem hiding this comment.
spigot uses "api-version:" in the plugin.yml not the version it was built with, protectionstones currently has "api-version: 1.17" which means it will load with spigot 1.17-1.21.5
There was a problem hiding this comment.
Shouldn't we be updating the plugin.yml then? I think we should do this version bump in a separate PR to better be able to test the side effects of bumping the version since we won't have their compatibility mode
| "Use this command to recalculate block types for PS regions in a world.\n\n" + bc + " admin fixregions", | ||
| bc + " admin fixregions", | ||
| false); | ||
| //add footer since it was missing |
There was a problem hiding this comment.
| //add footer since it was missing |
| } | ||
|
|
||
| // add line based on flag type | ||
| boolean isGroupValueAll = groupfValue.equalsIgnoreCase("all") || groupfValue.isEmpty();; |
There was a problem hiding this comment.
| boolean isGroupValueAll = groupfValue.equalsIgnoreCase("all") || groupfValue.isEmpty();; | |
| boolean isGroupValueAll = groupfValue.equalsIgnoreCase("all") || groupfValue.isEmpty(); |
2 participants
updated /ps admin to use textcomponents
(now has clickable commands)
https://i.gyazo.com/5c634bb06416755a101d7a9d43636988.mp4