feat: add option to install a specific EspoCRM version#10
Open
aberonni wants to merge 1 commit intoespocrm:masterfrom
Open
feat: add option to install a specific EspoCRM version#10aberonni wants to merge 1 commit intoespocrm:masterfrom
aberonni wants to merge 1 commit intoespocrm:masterfrom
Conversation
|
Did you test this script with -ssl flag? |
Author
|
@oussama-saoudi no, this adds a new parameter, it shouldn't (in theory) affect or change the behaviour of existing parameters. Are you asking because of issues? |
|
Yes, the SSL LetsEncrypt installation part is not working on the one I'm using, maybe you can give it a try on your side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6
I've tested this with a new installation and it works as expected.
If you'd like to test, you can use the code from our fork like so:
I think this is a nice addition, and valuable for the community, but I am also very open to feedback and adjustments if needed.