Open
Conversation
Collaborator
danielnottingham
left a comment
There was a problem hiding this comment.
I liked your solution! Maybe you could consider adding some test cases:
'imports a valid CSV file'
'handles an empty CSV file'
'returns an error for non-CSV files'
here I'm not sure if it's worth adding a test for this:
def encode_string(string)
string.force_encoding("ISO-8859-1").encode("UTF-8")
end
'handle CSV files that contain special characters'
Collaborator
Author
|
@danielnottingham thanks! I created the PR and I forgot to add tests. Soon I'll add the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.