Skip to content

Conversation

@nebkat
Copy link
Contributor

@nebkat nebkat commented Dec 18, 2025

Description

esp_ota_end() already performs ota_verify_partition() so there is no need for a second verification on esp_ota_set_boot_partition_without_validate().


Checklist

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Note

Introduces a no-validate boot-partition setter and refactors esp_ota_set_boot_partition() to validate then delegate; updates public header/docs accordingly.

  • OTA boot selection:
    • Add esp_ota_set_boot_partition_without_validate() in components/app_update/esp_ota_ops.c and declare it in include/esp_ota_ops.h.
    • Refactor esp_ota_set_boot_partition() to perform image validation then call esp_ota_set_boot_partition_without_validate().
  • API docs:
    • Document new function and note equivalence of esp_ota_set_boot_partition() to esp_image_verify() + esp_ota_set_boot_partition_without_validate().

Written by Cursor Bugbot for commit 47ab373. This will update automatically on new commits. Configure here.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello nebkat, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 47ab373

@github-actions github-actions bot changed the title feat(app_update): esp_ota_set_boot_partition_without_validate() feat(app_update): esp_ota_set_boot_partition_without_validate() (IDFGH-16972) Dec 18, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 18, 2025
* - ESP_ERR_NOT_FOUND: OTA data partition not found.
* - ESP_ERR_FLASH_OP_TIMEOUT or ESP_ERR_FLASH_OP_FAIL: Flash erase or write failed.
*/
esp_err_t esp_ota_set_boot_partition_without_validate(const esp_partition_t* partition);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using esp_ota_set_boot_partition_no_validate instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants