robustness: save report data before validation#21665
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #21665 +/- ##
==========================================
+ Coverage 70.30% 70.34% +0.04%
==========================================
Files 425 426 +1
Lines 35145 35139 -6
==========================================
+ Hits 24708 24720 +12
+ Misses 9044 9032 -12
+ Partials 1393 1387 -6 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
henrybear327
force-pushed
the
robustness/save_before_validation
branch
2 times, most recently
from
9b95016 to
72f4746
Compare
henrybear327
force-pushed
the
robustness/save_before_validation
branch
from
72f4746 to
0174c93
Compare
henrybear327
force-pushed
the
robustness/save_before_validation
branch
from
0174c93 to
18243cd
Compare
henrybear327
force-pushed
the
robustness/save_before_validation
branch
3 times, most recently
from
e0f2351 to
852cbcd
Compare
|
/retest |
1 similar comment
|
/retest |
Robustness reports used to be saved only when validation failed, that can leave no client or server artifacts to reproduce the run locally for debugging if the validation got killed by OOM on CI. This commit proposes that we save artifacts immediately after scenario traffic completes (before validation starts). Successful runs remove the per-test report directory unless PERSIST_RESULTS is set. Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
henrybear327
force-pushed
the
robustness/save_before_validation
branch
from
852cbcd to
a90a242
Compare
Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>
| r.visualize = visualize | ||
| } | ||
|
|
||
| func (r *TestReport) ReportData() error { |
There was a problem hiding this comment.
| func (r *TestReport) ReportData() error { | |
| func (r *TestReport) ReporEtcdtData() error { |
What data we report?
| return err | ||
| } | ||
| for server, dataPath := range r.ServersDataPath { | ||
| r.logger.Info("Saving robustness test report", zap.String("path", path)) |
There was a problem hiding this comment.
But the function was meant to save data?
|
@henrybear327: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Robustness reports used to be saved only when validation failed, that can leave no client or server artifacts to reproduce the run locally for debugging if the validation got killed by OOM on CI.
This commit proposes that we save artifacts immediately after scenario traffic completes (before validation starts).
Successful runs remove the per-test report directory unless PERSIST_RESULTS is set.