dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21675
dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21675jachym-tousek-keboola wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jachym-tousek-keboola The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jachym-tousek-keboola. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
68f682a to
d5c21af
Compare
Signed-off-by: Jáchym Toušek <jachym.tousek@keboola.com>
d5c21af to
ee3cfbf
Compare
Could you explain what are the issues? |
|
/ok-to-test |
|
@jachym-tousek-keboola: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 41 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #21675 +/- ##
===============================================
- Coverage 69.47% 68.92% -0.55%
===============================================
Files 405 420 +15
Lines 35419 35849 +430
===============================================
+ Hits 24606 24710 +104
- Misses 9364 9685 +321
- Partials 1449 1454 +5 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I'd like to backport #20008 to
release-3.6.We're using some etcd packages but we keep running into issues with
github.com/olekukonko/tablewriter. Other libraries want to update it but etcd 3.6 depends on the outdated version. It's already fixed for 3.7 but it doesn't look like it will be released any time soon so I'd prefer to not have to wait for it.