Skip to content

dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21675

Open
jachym-tousek-keboola wants to merge 1 commit into
etcd-io:release-3.6from
jachym-tousek-keboola:update-tablewriter
Open

dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21675
jachym-tousek-keboola wants to merge 1 commit into
etcd-io:release-3.6from
jachym-tousek-keboola:update-tablewriter

Conversation

@jachym-tousek-keboola
Copy link
Copy Markdown

@jachym-tousek-keboola jachym-tousek-keboola commented Apr 28, 2026

I'd like to backport #20008 to release-3.6.

  • Updates changes to version 1.1.x API to build tables.
  • Updates the bill of materials.

We're using some etcd packages but we keep running into issues with github.com/olekukonko/tablewriter. Other libraries want to update it but etcd 3.6 depends on the outdated version. It's already fixed for 3.7 but it doesn't look like it will be released any time soon so I'd prefer to not have to wait for it.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jachym-tousek-keboola
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @jachym-tousek-keboola. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jáchym Toušek <jachym.tousek@keboola.com>
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Apr 30, 2026

We're using some etcd packages but we keep running into issues with github.com/olekukonko/tablewriter

Could you explain what are the issues?

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Apr 30, 2026

/ok-to-test

@k8s-ci-robot
Copy link
Copy Markdown

@jachym-tousek-keboola: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify ee3cfbf link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.92%. Comparing base (7d4b175) to head (ee3cfbf).
⚠️ Report is 7 commits behind head on release-3.6.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/printer_table.go 0.00% 12 Missing ⚠️
etcdutl/etcdutl/printer_table.go 0.00% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdutl/etcdutl/printer_table.go 0.00% <0.00%> (ø)
etcdctl/ctlv3/command/printer_table.go 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #21675      +/-   ##
===============================================
- Coverage        69.47%   68.92%   -0.55%     
===============================================
  Files              405      420      +15     
  Lines            35419    35849     +430     
===============================================
+ Hits             24606    24710     +104     
- Misses            9364     9685     +321     
- Partials          1449     1454       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4b175...ee3cfbf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants