Suppress duplicated failed-test output in robustness CI logs#21712
Suppress duplicated failed-test output in robustness CI logs#21712henrybear327 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #21712 +/- ##
==========================================
+ Coverage 70.16% 70.26% +0.10%
==========================================
Files 426 426
Lines 35242 35242
==========================================
+ Hits 24726 24763 +37
+ Misses 9125 9091 -34
+ Partials 1391 1388 -3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/cc @ivanvc |
|
Successful
Failed I will trigger a failure intentionally to check the output (I can't figure out a way to reproduce the log generation locally... so I need to test it out here) |
|
Can you show "before vs after" comparison? A log example or screenshot. Also would be good to understand not only how it impacts robustness test but other tests too. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
For sure! That's what I am trying to gather now by intentionally failing the CI. |
|
Before and after runs (using as example the failed job):
Thanks for this, Henry. Two questions though:
|
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
7fb384a to
b174db3
Compare
|
@henrybear327: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
By default,
gotestsumprints a failure summary that includes full failed-test output. For verbose robustness failures, this duplicates large chunks of log output near the end of the Prow build log.The line below appears once in the live
go test -jsonoutput and again in the gotestsum failure summary:Example run: