Skip to content

Suppress duplicated failed-test output in robustness CI logs#21712

Draft
henrybear327 wants to merge 2 commits into
etcd-io:mainfrom
henrybear327:robustness/fix_duplicate_error_log
Draft

Suppress duplicated failed-test output in robustness CI logs#21712
henrybear327 wants to merge 2 commits into
etcd-io:mainfrom
henrybear327:robustness/fix_duplicate_error_log

Conversation

@henrybear327
Copy link
Copy Markdown
Contributor

By default, gotestsum prints a failure summary that includes full failed-test output. For verbose robustness failures, this duplicates large chunks of log output near the end of the Prow build log.

The line below appears once in the live go test -json output and again in the gotestsum failure summary:

logger.go:146: 2026-05-04T20:12:19.907Z INFO starting server... {"name": "TestRobustnessExploratoryKubernetesHighTrafficClusterOfSize1-test-0"}

Example run:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.26%. Comparing base (d5527f2) to head (b174db3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21712      +/-   ##
==========================================
+ Coverage   70.16%   70.26%   +0.10%     
==========================================
  Files         426      426              
  Lines       35242    35242              
==========================================
+ Hits        24726    24763      +37     
+ Misses       9125     9091      -34     
+ Partials     1391     1388       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5527f2...b174db3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Copy Markdown
Member

/cc @ivanvc

@k8s-ci-robot k8s-ci-robot requested a review from ivanvc May 6, 2026 06:18
@henrybear327 henrybear327 changed the title [PoC] [DO NOT REVIEW] Suppress duplicated failed-test output in robustness CI logs Suppress duplicated failed-test output in robustness CI logs May 6, 2026
@henrybear327 henrybear327 self-assigned this May 6, 2026
@henrybear327
Copy link
Copy Markdown
Contributor Author

henrybear327 commented May 6, 2026

Successful

Failed

I will trigger a failure intentionally to check the output (I can't figure out a way to reproduce the log generation locally... so I need to test it out here)

@serathius
Copy link
Copy Markdown
Member

Can you show "before vs after" comparison? A log example or screenshot. Also would be good to understand not only how it impacts robustness test but other tests too.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign ivanvc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrybear327
Copy link
Copy Markdown
Contributor Author

henrybear327 commented May 6, 2026

Can you show "before vs after" comparison? A log example or screenshot. Also would be good to understand not only how it impacts robustness test but other tests too.

For sure! That's what I am trying to gather now by intentionally failing the CI.

@ivanvc
Copy link
Copy Markdown
Member

ivanvc commented May 6, 2026

Before and after runs (using as example the failed job):

Thanks for this, Henry. Two questions though:

  1. Can you give more explanation on why we need 7fb384a? Maybe adding more context in the commit message (body) would help, too.
  2. Are the CI failures related to the PR changes or are they coincidental?

Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
@henrybear327 henrybear327 force-pushed the robustness/fix_duplicate_error_log branch from 7fb384a to b174db3 Compare May 20, 2026 08:19
@k8s-ci-robot
Copy link
Copy Markdown

@henrybear327: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-386 b174db3 link true /test pull-etcd-unit-test-386
pull-etcd-unit-test-arm64 b174db3 link true /test pull-etcd-unit-test-arm64
pull-etcd-unit-test-amd64 b174db3 link true /test pull-etcd-unit-test-amd64
pull-etcd-robustness-arm64 b174db3 link true /test pull-etcd-robustness-arm64
pull-etcd-coverage-report b174db3 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants