Skip to content

fix(etcdctl): parse lease txn compare values#21742

Open
loingtan wants to merge 1 commit into
etcd-io:mainfrom
loingtan:codex/lease-compare-regression
Open

fix(etcdctl): parse lease txn compare values#21742
loingtan wants to merge 1 commit into
etcd-io:mainfrom
loingtan:codex/lease-compare-regression

Conversation

@loingtan
Copy link
Copy Markdown

Summary

  • Fix etcdctl txn parsing for lease comparisons such as lease("foo") > "0".
  • Parse lease compare values as integers before constructing the client compare, matching revision/version compare parsing.
  • Add regression coverage for lease compare parsing.

Fixes #20773

Test Plan

  • go test ./etcdctl/... -count=1

Distributed systems note

Lease comparisons are part of etcd transaction conditions; this keeps CLI transaction parsing aligned with the lease ID semantics used by the client compare API.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @loingtan. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: loingtan
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

lease comparison in txn bug

2 participants