add RangeStream test for values exceeding chunk target#21746
Conversation
|
Hi @Jefftree. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
f38d1ab to
232f9a2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 42 files with indirect coverage changes @@ Coverage Diff @@
## main #21746 +/- ##
==========================================
- Coverage 70.28% 70.27% -0.02%
==========================================
Files 425 426 +1
Lines 35145 35212 +67
==========================================
+ Hits 24703 24746 +43
- Misses 9047 9073 +26
+ Partials 1395 1393 -2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
232f9a2 to
b11ed08
Compare
|
/retest |
e5a0f91 to
2373749
Compare
…target Signed-off-by: Jefftree <jeffrey.ying86@live.com>
8998f98 to
c5d1b8a
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, Jefftree, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could be an edge case where we have 4MB values or something. Ensure that RangeStream still progresses despite each chunk exceeding the preconfigured 1.5MB chunk limit.