Skip to content

add RangeStream test for values exceeding chunk target#21746

Merged
serathius merged 1 commit into
etcd-io:mainfrom
Jefftree:range-stream-large-values
May 14, 2026
Merged

add RangeStream test for values exceeding chunk target#21746
serathius merged 1 commit into
etcd-io:mainfrom
Jefftree:range-stream-large-values

Conversation

@Jefftree
Copy link
Copy Markdown
Member

Could be an edge case where we have 4MB values or something. Ensure that RangeStream still progresses despite each chunk exceeding the preconfigured 1.5MB chunk limit.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @Jefftree. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Jefftree
Copy link
Copy Markdown
Member Author

/ok-to-test

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.27%. Comparing base (b2a2cbb) to head (c5d1b8a).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files

see 42 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21746      +/-   ##
==========================================
- Coverage   70.28%   70.27%   -0.02%     
==========================================
  Files         425      426       +1     
  Lines       35145    35212      +67     
==========================================
+ Hits        24703    24746      +43     
- Misses       9047     9073      +26     
+ Partials     1395     1393       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a2cbb...c5d1b8a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jefftree Jefftree force-pushed the range-stream-large-values branch from 232f9a2 to b11ed08 Compare May 13, 2026 20:00
@Jefftree
Copy link
Copy Markdown
Member Author

/retest

Comment thread tests/integration/v3_grpc_test.go
@Jefftree Jefftree force-pushed the range-stream-large-values branch 3 times, most recently from e5a0f91 to 2373749 Compare May 14, 2026 13:50
…target

Signed-off-by: Jefftree <jeffrey.ying86@live.com>
@Jefftree Jefftree force-pushed the range-stream-large-values branch from 8998f98 to c5d1b8a Compare May 14, 2026 14:11
@Jefftree
Copy link
Copy Markdown
Member Author

/retest

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, Jefftree, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit c85940a into etcd-io:main May 14, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants