fix TestKVGet skip masking non-stream coverage#21748
Conversation
…e wantResponses Signed-off-by: Jefftree <jeffrey.ying86@live.com>
03d7766 to
5efa4a8
Compare
|
/cc @nwnt @serathius @fuweid |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 155 files with indirect coverage changes @@ Coverage Diff @@
## main #21748 +/- ##
==========================================
+ Coverage 64.41% 69.39% +4.98%
==========================================
Files 412 426 +14
Lines 34081 35215 +1134
==========================================
+ Hits 21952 24437 +2485
+ Misses 10595 9355 -1240
+ Partials 1534 1423 -111 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Stream subtest should only skip on stream=true instead of unconditionally, this was a regression caused by my rangestream change.
In the meantime, #21227 merged without the test running due to the regression. There are two incorrect tests that need to be updated.
Discovered while working on #21747
Using the values before as the source of truth: a516127, manually verified 2 test failures.
reversedKvs := []*mvccpb.KeyValue{kvFop, kvFooAbc, kvFoo, kvC, kvB, kvA}"all KVs with maximum mod revision, sorted by key descending" ->
[]*mvccpb.KeyValue{kvB, kvA}This should be
reversedKVs[4:]instead ofreveresdKVs[:2]allKvs := []*mvccpb.KeyValue{kvA, kvB, kvC, kvFoo, kvFooAbc, kvFop}kvsByValueDesc := []*mvccpb.KeyValue{kvFop, kvFoo, kvC, kvA, kvB, kvFooAbc}"all KVs with maximimum create revision, sorted by value" ->
[]*mvccpb.KeyValue{kvFoo, kvC, kvA, kvB}allKvs[:4]doesn't sort by value.kvsByValueDesc[1:5]has this sorted.