Skip to content

[release-3.5] Add write-only-skip-check option for --v2-deprecation to bypass the v2 content check#21897

Merged
fuweid merged 1 commit into
etcd-io:release-3.5from
sahilpatel09:skip-v2-datastore-check-for-3.5
Jun 3, 2026
Merged

[release-3.5] Add write-only-skip-check option for --v2-deprecation to bypass the v2 content check#21897
fuweid merged 1 commit into
etcd-io:release-3.5from
sahilpatel09:skip-v2-datastore-check-for-3.5

Conversation

@sahilpatel09
Copy link
Copy Markdown
Contributor

Originally solves #21250
This is a backport to v3.5 as mentioned in #21889: #21889 (comment)

I have not added tests just to keep it consistent with the previous PR.

Signed-off-by: Sahil Patel <smppatel999@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @sahilpatel09. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sahilpatel09
Copy link
Copy Markdown
Contributor Author

/cc @ahrtr

@k8s-ci-robot k8s-ci-robot requested a review from ahrtr June 3, 2026 17:58
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Jun 3, 2026

/ok-to-test

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Jun 3, 2026

Manually verified.

$ ./bin/etcd --v2-deprecation=write-only-skip-check
......
{"level":"warn","ts":"2026-06-03T19:18:53.087187+0100","caller":"etcdserver/server.go:731","msg":"WARNING: --v2-deprecation=write-only-skip-check is enabled; v2 content detected, but validation check is being bypassed"}
......

@ahrtr ahrtr requested a review from fuweid June 3, 2026 18:23
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

Pls also add a changelog for 3.5.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, sahilpatel09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fuweid fuweid merged commit 9fa3224 into etcd-io:release-3.5 Jun 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants