docs: add Docker installation instructions#1174
Conversation
|
Hi @uzairhameed. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi, @uzairhameed. Thanks for the pull request. Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e: git rebase HEAD~1 --signoff
git push --force |
3718595 to
dada013
Compare
@ivanvc I have signed the commit. Please let me know if anything else is needed. |
|
/ok-to-test |
|
@uzairhameed, to make the linter pass, I would suggest not touching anything but the fragment you're adding. Please also add this section for 3.5 and 3.7. Thanks :) |
|
/retest |
1 similar comment
|
/retest |
|
@ivanvc I have added the Docker section to 3.5 and v3.7 and tests passed. Please let me know if anything else is needed. |
Signed-off-by: Uzair Hameed <uzairhameed98@gmail.com>
23ebc02 to
41b3419
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, uzairhameed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a Docker section to the install page for v3.6, resolving the gap between the GitHub release notes and the official documentation.
The GitHub release notes (e.g. https://github.com/etcd-io/etcd/releases/tag/v3.6.12) currently include installation instructions for Linux, macOS, and Docker. The official install page (https://etcd.io/docs/v3.6/install/) already covers Linux and macOS, but was missing Docker instructions entirely.
As part of the effort to move installation instructions out of the release notes and into the official docs (#1174), this PR adds the missing Docker section.
Changes:
## Dockersection tocontent/en/docs/v3.6/install.mdgcr.io/etcd-development/etcd(primary) andquay.io/coreos/etcd(secondary){{< param git_version_tag >}}to keep the version referenceconsistent with the rest of the page
Closes #1172