Skip to content

Implement de_json method in UniqueGiftColors#2559

Merged
Badiboy merged 2 commits into
eternnoir:masterfrom
glader:patch
Feb 16, 2026
Merged

Implement de_json method in UniqueGiftColors#2559
Badiboy merged 2 commits into
eternnoir:masterfrom
glader:patch

Conversation

@glader

@glader glader commented Feb 16, 2026

Copy link
Copy Markdown
Contributor
  File "telebot/types.py", line 794, in de_json
    obj['unique_gift_colors'] = UniqueGiftColors.de_json(obj['unique_gift_colors'])
  File "telebot/types.py", line 89, in de_json
    raise NotImplementedError
NotImplementedError: null

Description

Include changes, new features and etc:

Describe your tests

How did you test your change?

Python version:

OS:

Checklist:

  • I added/edited example on new feature/change (if exists)
  • My changes won't break backward compatibility
  • I made changes both for sync and async

@glader

glader commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for spaces changing, PyCharm...

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the missing de_json deserialization method for the UniqueGiftColors class to fix a NotImplementedError that was being raised when attempting to deserialize unique gift colors data from JSON.

Changes:

  • Added de_json classmethod implementation to UniqueGiftColors class
  • Removed trailing whitespace from several lines throughout the file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread telebot/types.py
@Badiboy

Badiboy commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

@Badiboy Badiboy merged commit 532d3eb into eternnoir:master Feb 16, 2026
12 checks passed
@glader

glader commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Badiboy. Do you have any plans for a new release of the library? Just wanted to check in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants