batwatch: Show 'Command:' instead of 'File:' in header of command mode#148
Open
frankenstein91 wants to merge 1 commit into
Open
batwatch: Show 'Command:' instead of 'File:' in header of command mode#148frankenstein91 wants to merge 1 commit into
frankenstein91 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
batwatch --command <cmd>, the header rendered bybatdisplaysFile: <cmd>. Since it is executing a command rather than displaying a file, it is more appropriate and intuitive to displayCommand: <cmd>.This PR post-processes the
batoutput inbatwatch's command execution loop using a portablesedreplacement that targets only the first 5 lines (the header block), changingFile:toCommand:.Changes
src/batwatch.sh: Added a portable Basic Regular Expression (BRE)sedfilter in the output capturing pipeline to replace theFile:label withCommand:.test/suite/batwatch.sh: Added thetest:command_headertest case to verify that the header correctly usesCommand:when executing a command.Verification
Tested both the raw script and the compiled version using the test suite:
./test.sh(allbatwatchtests pass)./build.sh && ./test.sh --compiled(allbatwatchtests pass)