Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ permissions:
# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
concurrency:
group: "pages"
group: "pages-${{ github.head_ref || github.ref_name }}"
cancel-in-progress: false
Comment on lines 21 to 23

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Pr blocks main deploy 🐞 Bug ☼ Reliability

The workflow-wide concurrency key uses github.head_ref for pull_request runs, so a PR whose source
branch is named main will share the same group (pages-main) as push-to-main runs and can
queue/delay production deployments. Because cancel-in-progress: false, a long PR build can block
subsequent main deployments until it completes.
Agent Prompt
## Issue description
The workflow-level `concurrency.group` is derived from `github.head_ref || github.ref_name`, which can produce the same group name for different event types (notably `pull_request` vs `push`). This can cause non-deploying PR runs to block production deploy runs when the PR source branch name matches the protected branch name (e.g., `main`).

## Issue Context
This workflow runs on both `push` to `main` and `pull_request` targeting `main`, but only deploys when `github.ref == 'refs/heads/main'`.

## Fix Focus Areas
- .github/workflows/build-ui.yml[21-23]

## Suggested change
Make the concurrency key unique across event types (or use `github.ref`), e.g.:
- `group: "pages-${{ github.event_name }}-${{ github.head_ref || github.ref_name }}"`

This keeps branch-based grouping while preventing `pull_request` runs from sharing the same key as `push` runs on `main`.

β“˜ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


jobs:
Expand Down