Skip to content

Conversation

@MarcoPolo
Copy link
Contributor

CL clients can make use of partial responses to exchange just the missing cells. This method allows the CL to request partial responses from the EL.

This method is identical to getBlobsV2 but returns null entries if a blob is not available locally.

See https://ethresear.ch/t/gossipsubs-partial-messages-extension-and-cell-level-dissemination/23017 for context on cell level dissemination. See #674 for the prior version of this PR. That PR was closed to avoid adding a new requirement to Fusaka.

The changes here are currently in ./src/engine/osaka.md, but I'm happy to move them to a new file if folks prefer that. Maybe titled osaka-BPO-X.md where X is the BPO number we want these changes to be available in?

Implementing this method is not mandatory as CL clients can fallback to getBlobsV2. However for cell level dissemination to be useful, the EL needs to provide this method.

@mkalinin
Copy link
Contributor

I think appending it to Osaka is fine if this method is about to be rolled out before Amsterdam. We had such precedent before with getBlobsV1 that was added to Cancun after the hard fork has happened

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a doctoc run. I tried pushing it to your branch but didn't have perms. Other than that, LGTM!

# install doctoc first
$ doctoc ./src/engine/osaka.md

CL clients can make use of partial responses to exchange just the
missing cells. This method allows the CL to request partial responses
from the EL.

Co-Authored-By: raulk <raul.kripalani@gmail.com>
@MarcoPolo
Copy link
Contributor Author

CI failing due to #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants