-
Notifications
You must be signed in to change notification settings - Fork 397
enhance(ci): Add EIP Tracker Issue Template #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1847 +/- ##
============================================
Coverage 83.87% 83.87%
============================================
Files 402 402
Lines 25101 25101
Branches 2285 2285
============================================
Hits 21053 21053
Misses 3609 3609
Partials 439 439
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Carsons-Eels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts/suggestions
spencer-tb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding a phase 1 (CFI'd) & phase 2 (SFI'd) to the Process Status section could be nice! Phase 1 would be for initial tests, and included in the devnet. Phase 2 would be for. spec/test coverage reviewed by 2 EELS / 2 EEST / 1 EIP author, extra tests added and passing, EIP successful in first testnet.
We could add a regressions section to. For significant changes, whether there are issues that come up during a devnet, missed test coverage or even whether the EIP is pulled out of the fork (and the reasons why).
Let me know what you think! Happy to merge now and get the process going nonetheless.
fselmo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, ty! ππΌ
Co-authored-by: Carson <carson@binarycake.ca>
Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: Carson <carson@binarycake.ca>
Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: felipe <fselmo2@gmail.com>
b98f486 to
835f449
Compare
* benchmark: add CREATE coverage Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * benchmark: add CREATE2 coverage Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * benchmark: add CREATE2 collisions coverage Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix msize problem Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * benchmark: add CREATE collisions coverage Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * typo Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * nit Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update tests/benchmark/test_worst_bytecode.py Co-authored-by: Mario Vega <marioevz@gmail.com> * improvements Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * improvements Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * improvements Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lints Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Mario Vega <marioevz@gmail.com>
* enhance(ci): Add EIP Tracker Issue Template * Add note and paraphrase. * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson <carson@binarycake.ca> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer <spencer.tb@ethereum.org> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson <carson@binarycake.ca> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer <spencer.tb@ethereum.org> * Review feedback * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml * Apply suggestions from code review Co-authored-by: felipe <fselmo2@gmail.com> * Review comments * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml --------- Co-authored-by: Carson <carson@binarycake.ca> Co-authored-by: spencer <spencer.tb@ethereum.org> Co-authored-by: felipe <fselmo2@gmail.com>
* enhance(ci): Add EIP Tracker Issue Template * Add note and paraphrase. * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson <carson@binarycake.ca> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer <spencer.tb@ethereum.org> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson <carson@binarycake.ca> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer <spencer.tb@ethereum.org> * Review feedback * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml * Apply suggestions from code review Co-authored-by: felipe <fselmo2@gmail.com> * Review comments * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml --------- Co-authored-by: Carson <carson@binarycake.ca> Co-authored-by: spencer <spencer.tb@ethereum.org> Co-authored-by: felipe <fselmo2@gmail.com>
* enhance(ci): Add EIP Tracker Issue Template * Add note and paraphrase. * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson <carson@binarycake.ca> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer <spencer.tb@ethereum.org> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson <carson@binarycake.ca> * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer <spencer.tb@ethereum.org> * Review feedback * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml * Apply suggestions from code review Co-authored-by: felipe <fselmo2@gmail.com> * Review comments * Update .github/ISSUE_TEMPLATE/eip-tracker.yaml --------- Co-authored-by: Carson <carson@binarycake.ca> Co-authored-by: spencer <spencer.tb@ethereum.org> Co-authored-by: felipe <fselmo2@gmail.com>
ποΈ Description
Adds a tracker issue template for EIPs to help better monitor the specification and testing progress.
π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture