Skip to content

Conversation

@marioevz
Copy link
Member

@marioevz marioevz commented Dec 4, 2025

πŸ—’οΈ Description

Adds a tracker issue template for EIPs to help better monitor the specification and testing progress.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 83.87%. Comparing base (2f15886) to head (835f449).
⚠️ Report is 5 commits behind head on forks/osaka.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1847   +/-   ##
============================================
  Coverage        83.87%   83.87%           
============================================
  Files              402      402           
  Lines            25101    25101           
  Branches          2285     2285           
============================================
  Hits             21053    21053           
  Misses            3609     3609           
  Partials           439      439           
Flag Coverage Ξ”
unittests 83.87% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Carsons-Eels Carsons-Eels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts/suggestions

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a phase 1 (CFI'd) & phase 2 (SFI'd) to the Process Status section could be nice! Phase 1 would be for initial tests, and included in the devnet. Phase 2 would be for. spec/test coverage reviewed by 2 EELS / 2 EEST / 1 EIP author, extra tests added and passing, EIP successful in first testnet.

We could add a regressions section to. For significant changes, whether there are issues that come up during a devnet, missed test coverage or even whether the EIP is pulled out of the fork (and the reasons why).

Let me know what you think! Happy to merge now and get the process going nonetheless.

@marioevz marioevz requested a review from fselmo December 8, 2025 18:05
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, ty! πŸ™πŸΌ

@marioevz marioevz force-pushed the eip-tracker-template branch from b98f486 to 835f449 Compare December 8, 2025 19:23
@marioevz marioevz merged commit 0b903cc into ethereum:forks/osaka Dec 8, 2025
11 checks passed
@marioevz marioevz deleted the eip-tracker-template branch December 8, 2025 23:37
SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
* benchmark: add CREATE coverage

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* benchmark: add CREATE2 coverage

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* benchmark: add CREATE2 collisions coverage

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fix msize problem

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* benchmark: add CREATE collisions coverage

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* typo

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* nit

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update tests/benchmark/test_worst_bytecode.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* improvements

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* improvements

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* improvements

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* lints

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
jochem-brouwer pushed a commit to jochem-brouwer/execution-specs that referenced this pull request Dec 11, 2025
* enhance(ci): Add EIP Tracker Issue Template

* Add note and paraphrase.

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: Carson <carson@binarycake.ca>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: spencer <spencer.tb@ethereum.org>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: Carson <carson@binarycake.ca>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: spencer <spencer.tb@ethereum.org>

* Review feedback

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

* Apply suggestions from code review

Co-authored-by: felipe <fselmo2@gmail.com>

* Review comments

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

---------

Co-authored-by: Carson <carson@binarycake.ca>
Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: felipe <fselmo2@gmail.com>
jochem-brouwer pushed a commit to jochem-brouwer/execution-specs that referenced this pull request Dec 11, 2025
* enhance(ci): Add EIP Tracker Issue Template

* Add note and paraphrase.

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: Carson <carson@binarycake.ca>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: spencer <spencer.tb@ethereum.org>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: Carson <carson@binarycake.ca>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: spencer <spencer.tb@ethereum.org>

* Review feedback

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

* Apply suggestions from code review

Co-authored-by: felipe <fselmo2@gmail.com>

* Review comments

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

---------

Co-authored-by: Carson <carson@binarycake.ca>
Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: felipe <fselmo2@gmail.com>
LouisTsai-Csie pushed a commit to LouisTsai-Csie/execution-specs that referenced this pull request Dec 12, 2025
* enhance(ci): Add EIP Tracker Issue Template

* Add note and paraphrase.

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: Carson <carson@binarycake.ca>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: spencer <spencer.tb@ethereum.org>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: Carson <carson@binarycake.ca>

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

Co-authored-by: spencer <spencer.tb@ethereum.org>

* Review feedback

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

* Apply suggestions from code review

Co-authored-by: felipe <fselmo2@gmail.com>

* Review comments

* Update .github/ISSUE_TEMPLATE/eip-tracker.yaml

---------

Co-authored-by: Carson <carson@binarycake.ca>
Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: felipe <fselmo2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants