Use the new eth-keyfile module, fixes #292#293
Use the new eth-keyfile module, fixes #292#293AndreMiras wants to merge 1 commit intoethereum:developfrom
Conversation
Use the new eth-keyfile module to encrypt/decrypt keyfile. This makes it way faster to create and unlock accounts. For instance with 100K PBKDF2 iteration rather than 100. Running `pyethapp/tests/test_accounts.py` was outputing: ``` 9 passed in 112.07 seconds ``` After the pull request it's now: ``` 9 passed in 2.41 seconds ```
|
pyethapp is not upgraded to python3 so it is not compatible with eth-keys |
|
Hi @alexandermuehle thank you for your feedback! |
|
If I remember correctly json-rpc functions didn't work under python3 when I last tried it under py3, but I agree since the rest of the eth projects seem to be moving towards python3, this project should follow. |
|
@vbuterin @ChihChengLiang @pipermerriam @hwwhww @changwu-tw |
|
To the best of my knowledge this project is largely unmaintained. If you're looking for a python ethereum node, check out trinity which is currently being developed within the py-evm codebase |
|
thanks for clearing it up @pipermerriam, maybe add a "deprecated" note on the pyethapp readme so people find the right python implementation |
Use the new eth-keyfile module to encrypt/decrypt keyfile.
This makes it way faster to create and unlock accounts.
For instance with 100K PBKDF2 iteration rather than 100.
Running
pyethapp/tests/test_accounts.pywas outputing:After the pull request it's now: