-
Notifications
You must be signed in to change notification settings - Fork 52
New Features - val linking role, cross pod approval, consol. ratelimiting #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pankajjagtapp
wants to merge
13
commits into
master
Choose a base branch
from
pankaj/feat/add-cross-pod-approval
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d validating array lengths for validator IDs, public keys, and signatures in the deposit function.
📊 Forge Coverage ReportGenerated by workflow run #570 |
…ontract on mainnet
…ifier in EtherFiNodesManager contract
…oyment consistency
…g LiquidityPool and EtherFiNodesManager implementations
… in EtherFiNodesManager
…d upgrade functionality
…Limiter setup and address changes
cad692f to
32ef74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds access control and rate limiting to nodes management, enables cross-pod validator approval, and provides upgrade automation.
ETHERFI_NODES_MANAGER_LEGACY_LINKER_ROLE;linkLegacyValidatorIdsnowonlyLegacyLinker. Consolidation remains gated byETHERFI_NODES_MANAGER_EL_CONSOLIDATION_ROLE.CONSOLIDATION_REQUEST_LIMIT_ID;requestConsolidationnow consumes from rate limiter usinggetTotalConsolidationGwei(counts true consolidations, ignores credential switches).batchApproveRegistrationnow validates array lengths (InvalidArrayLengths), deriveseigenPod/withdrawal credentials per validator, and removes same-node constraint to allow cross-pod approvals.CONSOLIDATION_REQUEST_LIMIT_IDinIEtherFiNodesManager.deploy.s.solandtransactions.s.solto deploy new implementations, perform UUPS upgrades via timelock, and grant legacy linker role; includes optional rate limiter setup and bytecode verification.Liquifier.t.sol.Written by Cursor Bugbot for commit 32ef74f. This will update automatically on new commits. Configure here.