Skip to content

Conversation

@pankajjagtapp
Copy link
Contributor

@pankajjagtapp pankajjagtapp commented Jan 6, 2026

Note

Adds access control and rate limiting to nodes management, enables cross-pod validator approval, and provides upgrade automation.

  • Roles & access control: New ETHERFI_NODES_MANAGER_LEGACY_LINKER_ROLE; linkLegacyValidatorIds now onlyLegacyLinker. Consolidation remains gated by ETHERFI_NODES_MANAGER_EL_CONSOLIDATION_ROLE.
  • Rate limiting: New CONSOLIDATION_REQUEST_LIMIT_ID; requestConsolidation now consumes from rate limiter using getTotalConsolidationGwei (counts true consolidations, ignores credential switches).
  • LiquidityPool changes: batchApproveRegistration now validates array lengths (InvalidArrayLengths), derives eigenPod/withdrawal credentials per validator, and removes same-node constraint to allow cross-pod approvals.
  • Interfaces: Expose CONSOLIDATION_REQUEST_LIMIT_ID in IEtherFiNodesManager.
  • Upgrade scripts: deploy.s.sol and transactions.s.sol to deploy new implementations, perform UUPS upgrades via timelock, and grant legacy linker role; includes optional rate limiter setup and bytecode verification.
  • Tests: Update/extend tests for new role gating and consolidation bucket; add Pectra consolidation fork tests; adjust minor assertion tolerance in Liquifier.t.sol.

Written by Cursor Bugbot for commit 32ef74f. This will update automatically on new commits. Configure here.

…d validating array lengths for validator IDs, public keys, and signatures in the deposit function.
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

📊 Forge Coverage Report

forge coverage failed; see logs above (tests step is the gate).

Generated by workflow run #570

@pankajjagtapp pankajjagtapp changed the title Enhance LiquidityPool contract by adding InvalidArrayLengths error an… Cross Pod Approval and LEGACY_LINKER_ROLE Jan 6, 2026
@pankajjagtapp pankajjagtapp self-assigned this Jan 6, 2026
@pankajjagtapp pankajjagtapp added the enhancement New feature or request label Jan 9, 2026
@pankajjagtapp pankajjagtapp changed the title Cross Pod Approval and LEGACY_LINKER_ROLE New Features - val linking role, cross pod approval, consol. ratelimiting Jan 13, 2026
@pankajjagtapp pankajjagtapp marked this pull request as draft January 13, 2026 20:29
@pankajjagtapp pankajjagtapp force-pushed the pankaj/feat/add-cross-pod-approval branch from cad692f to 32ef74f Compare January 15, 2026 16:28
@pankajjagtapp pankajjagtapp marked this pull request as ready for review January 15, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants