Skip to content

fix(api): resolve pinning failures for erasure-coded chunk #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gacevicljubisa wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix(api): resolve pinning failures for erasure-coded chunk #5230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fd1cc3
fix(api): use replicas getter for pinning erasure-coded chunks
gacevicljubisa Sep 26, 2025
92ad754
fix(api): use replicas.NewGetter for pinning
gacevicljubisa Sep 29, 2025
116928a
fix(api): revert changes not related to PR
gacevicljubisa Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/api/pin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (

"github.com/ethersphere/bee/v2/pkg/file/redundancy"
"github.com/ethersphere/bee/v2/pkg/jsonhttp"
"github.com/ethersphere/bee/v2/pkg/replicas"
"github.com/ethersphere/bee/v2/pkg/storage"
"github.com/ethersphere/bee/v2/pkg/storer"
"github.com/ethersphere/bee/v2/pkg/swarm"
Expand Down Expand Up @@ -52,7 +53,7 @@ func (s *Service) pinRootHash(w http.ResponseWriter, r *http.Request) {
return
}

getter := s.storer.Download(true)
Copy link
Member

@zelig zelig Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this does what we need.
What caused the problem and how did you fix it?

Honestly, I dont this replicas (as opposed to parities) should be pinned at all, cos they are the same as the root chunk. When it comes to repair it should just upload the replicas too to swarm .

Also it is very suspicious that redundancy.DefaultLevel is used here. You know the level of a pinned file we can assume, no?

Copy link
Member Author

@gacevicljubisa gacevicljubisa Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea behind this PR was to addresses just specific comment in issue #5228 .

Thanks for clarifying that replicas shouldn't be pinned.
I used redundancy.DefaultLevel as an assumption, and it is much used all over the codebase. Recently I created new issue related to the use of redundancy.DefaultLevel and inconsistent Swarm-Redundancy-Level header.

I wasn't aware we can extract the redundancy level from the pinned file.

Can you suggest me the flow, how pinning should be handled if route chunk can not be found?

Also, how we can repair by uploading the replicas too to swarm?

getter := replicas.NewGetter(s.storer.Download(true), redundancy.DefaultLevel)
traverser := traversal.New(getter, s.storer.Cache(), redundancy.DefaultLevel)

sem := semaphore.NewWeighted(100)
Expand Down
Loading