test(spinlock): add synctest to wait test #5260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the spinlock package tests to use Go's testing/synctest package for deterministic time-based testing, and temporarily restricts CI test execution to only the spinlock package.
- Wraps time-sensitive test cases with
synctest.Test()for controlled time simulation - Restricts CI test targets (
test-ci,test-ci-race) to run only./pkg/spinlockinstead of all packages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/spinlock/wait_test.go | Adds testing/synctest import and wraps test logic in synctest.Test() calls for deterministic time testing |
| Makefile | Restricts test-ci and test-ci-race targets to only run pkg/spinlock tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
acud
approved these changes
Nov 21, 2025
Contributor
acud
left a comment
acud
left a comment
There was a problem hiding this comment.
revert Makefile, otherwise LGTM
martinconic
approved these changes
Nov 22, 2025
janos
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Add synctest in wait test.
Remove parallel execution from tests (synctest).
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#5232
Screenshots (if appropriate):