Skip to content

Conversation

@AngheloAlf
Copy link
Collaborator

#515 introduced the ability to detect ori symbol pairs in the N64 entrypoint, but this introduced a bug that made create_config to emit incorrect relocations in the generated reloc_addrs.txt.

The bug was that it was emitting %lo relocations for those ori instructions, which produces non matching builds because %lo produces a signed operation but ori expects an unsigned argument.

With the fix now we keep track of ori pairs and only emit the reloc information if the pair was not created by using an ori.

I updated the entrypoint tests to account for this. I also fixed the arguments of the entrypoint instructions so it uses negative values for instructions that expect a signed value.

Finally I changed the CI to explicitly check all the python files, because mypy was barking at me about the entrypoints file but we weren't covering it in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant