cli: Fix incorrect comment #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A URL without a scheme is NOT a relative URL. Unfortunately I used this wrong term in a bunch of commit messages before. Sorry for the confusion. Fortunately I didn't use the term in any place of the code, except this very comment, so fix it now. For the avid reader: Wikipedia tells us that we can use the term "Protocol-relative URLs": > Protocol-relative links (PRL), also known as protocol-relative URLs > (PRURL), are URLs that have no protocol specified. For example, > `//example.com` will use the protocol of the current page, typically > HTTP or HTTPS However that's not what we use for HTTP+HTTPS mirrors, we use URLs that have only a host and a path. I'm still looking for the right term for that, if any...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A URL without a scheme is NOT a relative URL.
Unfortunately I used this wrong term in a bunch of commit messages before. Sorry for the confusion.
Fortunately I didn't use the term in any place of the code, except this very comment, so fix it now.
For the avid reader: Wikipedia tells us that we can use the term "Protocol-relative URLs":
However that's not what we use for HTTP+HTTPS mirrors, we use URLs that have only a host and a path. I'm still looking for the right term for that, if any...