Skip to content

Conversation

@elboulangero
Copy link
Contributor

@elboulangero elboulangero commented Jun 5, 2025

If the database is not reachable for some reason, mirrorbits must not return "500 Internal Server Error", instead it must redirect users to the fallback mirror(s).

This was broken in ed1db9e, here's the fix.

The pull request also adds copious unit testing for the http mirror handler.

Needed for the next commit, where we need to create Fallback structs for
testing.
It demonstrates the regression reported at
etix#195
If the database is not reachable for some reason, mirrorbits must not
return "500 Internal Server Error", instead it must redirect users to
the fallback mirror(s).

This was broken in ed1db9e, here's the
fix.

Closes: etix#195
@jbkempf jbkempf merged commit b17e39b into etix:master Jun 5, 2025
3 checks passed
@jbkempf
Copy link
Collaborator

jbkempf commented Jun 5, 2025

This is serious.

We need to do another release this quarter if we find more regressions…

@elboulangero
Copy link
Contributor Author

I added a minor improvement at #197. I'd be in favor of doing a new release after that, whenever you want. I can update the CHANGELOG if you want, just ping me. Thanks!

@jbkempf
Copy link
Collaborator

jbkempf commented Jun 5, 2025

I added a minor improvement at #197. I'd be in favor of doing a new release after that, whenever you want. I can update the CHANGELOG if you want, just ping me. Thanks!

I will need that, yes.

@jbkempf jbkempf added this to the v0.6.1 milestone Jun 5, 2025
@elboulangero elboulangero deleted the fix-internal-server-error-regressions branch June 5, 2025 08:44
@elboulangero
Copy link
Contributor Author

@jbkempf Do you want to cut a release? I'm waiting for that before I can open new MRs.

Moreover I noticed that Tails switched to 0.6 already: https://download.tails.net/tails/?mirrorstats

@jbkempf
Copy link
Collaborator

jbkempf commented Jul 14, 2025

@jbkempf Do you want to cut a release? I'm waiting for that before I can open new MRs.

I think we should. But you shouldn ´t wait to open new MRs, tbh :D

@jbkempf
Copy link
Collaborator

jbkempf commented Aug 16, 2025

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants