Skip to content

Conversation

@peter279k
Copy link

@peter279k peter279k commented Aug 17, 2020

Changed log

  • Add php-7.2,php-7.3 and php-7.4 tests during Travis CI build.
  • It's time to use the short array syntax to replace array syntax because this package requires php-5.6 at least.
  • Remove additional white spaces on all PHP codes.
  • Add visible syntax (public/protected/private) to let developers know the method is visible/invisible.

@peter279k peter279k requested a review from a team as a code owner August 17, 2020 05:52
"require-dev": {
"phpunit/phpunit": ">=5.5.0",
"mikey179/vfsStream": "~1"
"phpunit/phpunit": "^5.5",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • To avoid latest PHPUnit version installed and unexpected issues, it should let PHPUnit install with 5.5.x versions.

To fix following message, it should be mikey179/vfsstream.

Deprecation warning: require-dev.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead. Make sure you fix this as Composer 2.0 will error.


before_script:
- composer self-update
- composer install --prefer-source --no-interaction --dev
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove --dev to avoid following message:

You are using the deprecated option "dev". Dev packages are installed by default now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant