Skip to content

feat(api): Apply custom headers from the api command - #6

Open
euxaristia wants to merge 1 commit into
mainfrom
feat/api-headers
Open

feat(api): Apply custom headers from the api command#6
euxaristia wants to merge 1 commit into
mainfrom
feat/api-headers

Conversation

@euxaristia

Copy link
Copy Markdown
Owner

Summary

gt api advertised a --header/-H flag, but the handler discarded it with _ = headers, so custom headers were never sent. This wires the flag through to the request. Useful for endpoints that need a non-default Accept, Content-Type, or other header.

Changes

internal/api/client.go

  • Add RequestWithHeaders; Request now delegates to it with no extra headers, preserving the existing signature.
  • Preserve custom headers across GET retries by cloning the original request headers onto the rebuilt request in doWithRetry.

internal/cmd/api.go

  • Parse -H key:value headers and pass them to RequestWithHeaders for both the DELETE and general paths.
  • Add splitHeader, which splits on the first colon and validates a non-empty key.

Test plan

  • go build ./... clean
  • go vet ./internal/api/ ./internal/cmd/ clean
  • go test ./internal/api/ ./internal/cmd/ -run TestApi pass (8/8 api command tests)

The api command defined a --header/-H flag but discarded its value
(_ = headers), so custom headers were never sent. Add
RequestWithHeaders to the client, parse key:value headers in the api
command, and apply them to the outgoing request. Header values are also
preserved across GET retries by cloning the original request headers
onto the rebuilt request.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@euxaristia, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bf7cc3b1-00be-4c89-a37b-24348d7fc63a

📥 Commits

Reviewing files that changed from the base of the PR and between d880cc3 and 9076583.

📒 Files selected for processing (2)
  • internal/api/client.go
  • internal/cmd/api.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant