fix(git): Remove unreachable return in runGitWithRetry - #8
Conversation
The loop in runGitWithRetry always returned from inside its body (success path, or the final-iteration error path), so the trailing `return nil` was dead code. When retries were exhausted on only transient errors, the function incorrectly reported success. Break out of the loop on a terminal/non-transient error instead, and have the function end by returning a wrapped error that reflects the last failure. The terminal return is now the actual path taken when all retry attempts are consumed by transient errors.
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
runGitWithRetryhad an unreachablereturn nilat the end of the function. The loop body always returned (success, or a wrapped error on the final attempt / non-transient error), so the trailing return could never execute. Worse, if every retry attempt failed with a transient error, the function silently reported success instead of a failure.Changes
internal/cmd/git.golastErr.breakout of the loop on the terminal attempt or a non-transient error, instead of returning inside the loop.lastErr, which is the genuine path when all retries are exhausted by transient errors.git <op> failed: <err>is preserved.Test plan
go build ./...cleango vet ./internal/cmd/cleango test ./internal/cmd/pass