π‘οΈ Sentinel: [CRITICAL] Fix API key leak in streaming dictation#4
π‘οΈ Sentinel: [CRITICAL] Fix API key leak in streaming dictation#4euxaristia wants to merge 1 commit into
Conversation
π¨ Severity: CRITICAL π‘ Vulnerability: Streaming dictation (Deepgram, OpenAI Realtime) did not redact API keys from connection errors or websocket payload error responses. π― Impact: API keys injected into streaming websocket URLs or headers could be leaked in logs or outputs when transport-level errors occur or when the server responds with a typed error payload echoing the key. π§ Fix: Applied `providerio.Redact` around all error endpoints and websocket error returns for Deepgram and OpenAI Realtime transcribers. Changed `fmt.Errorf` format specifier from `%w` to `%s` to prevent leaking the unredacted error via `errors.Unwrap()`. β Verification: Ran `go test ./internal/dictation/...` and `make lint`. Co-authored-by: euxaristia <25621994+euxaristia@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review detailsβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (4)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Zero automated PR reviewVerdict: No blockers found Blockers
Validation
ScopeHead: This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality. |
π‘οΈ Sentinel: [CRITICAL] Fix API key leak in streaming dictation
π¨ Severity: CRITICAL
π‘ Vulnerability: Streaming dictation (Deepgram, OpenAI Realtime) did not redact API keys from connection errors or websocket payload error responses.
π― Impact: API keys injected into streaming websocket URLs or headers could be leaked in logs or outputs when transport-level errors occur or when the server responds with a typed error payload echoing the key.
π§ Fix: Applied
providerio.Redactaround all error endpoints and websocket error returns for Deepgram and OpenAI Realtime transcribers. Changedfmt.Errorfformat specifier from%wto%sto prevent leaking the unredacted error viaerrors.Unwrap().β Verification: Ran
go test ./internal/dictation/...andmake lint.PR created automatically by Jules for task 13047065217895425372 started by @euxaristia