Skip to content

always use std::any if C++17 if available #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evaleev merged 2 commits into from
Jan 12, 2026
Merged

always use std::any if C++17 if available #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4beeb
fixup libint::any to handle copies of null objects correctly
evaleev Jan 12, 2026
f745471
always assume std::any is available if C++17 is available
evaleev Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions include/libint2/util/any.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,9 @@

// Include C++17 any header, if available AND functional
#if __cplusplus >= 201703L
// macos < 10.14 do not have any_cast in their libc++
#include <ciso646> // see https://stackoverflow.com/a/31658120
#if defined(_LIBCPP_VERSION) && defined(__APPLE__)
#include <Availability.h>
#ifdef __MAC_OS_X_VERSION_MIN_ALLOWED
#if __MAC_OS_X_VERSION_MIN_ALLOWED >= 10140
#define LIBINT_HAS_CXX17_ANY
#endif // 10.14 or later
#endif // have macos version
#else // libc++ on macos
#define LIBINT_HAS_CXX17_ANY
#endif // libc++ on macos
#endif // c++17

#ifdef LIBINT_HAS_CXX17_ANY
#include <any>
#endif
#endif // c++17

namespace libint2 {

Expand All @@ -68,7 +54,7 @@ class any {
public:
// this is constexpr in the standard
any() : impl_(nullptr) {}
any(const any& other) : impl_(other.impl_->clone()) {}
any(const any& other) : impl_(other.impl_ ? other.impl_->clone() : nullptr) {}
any(any&& other) = default;
template <typename ValueType,
typename = detail::disable_if_same_or_derived<any, ValueType> >
Expand All @@ -78,7 +64,7 @@ class any {
~any() = default;

any& operator=(const any& rhs) {
impl_ = decltype(impl_)(rhs.impl_->clone());
impl_ = decltype(impl_)(rhs.impl_ ? rhs.impl_->clone() : nullptr);
return *this;
}
any& operator=(any&& rhs) {
Expand Down
Loading