schema builder fluency (fixes #303)#390
schema builder fluency (fixes #303)#390JoshMcCullough wants to merge 4 commits intoeverit-org:masterfrom
Conversation
|
I'm trying to figure out how to instruct japicmp that it's okay that I renamed that class since this would be released as a new major... |
|
Okay, updated the japicmp config to allow these changes for a major bump. |
|
Hello @JoshMcCullough , thank you for your work on this. I'm afraid we won't break backward-compatibility and increment the major version number for the purpose of this single fix (and other potential breaking changes are not under discussion right now). |
|
@erosb I understand the hesitance. And I can work with it using my own fork. I will just point out that creating a fluent schema as it is now is possible. But a general user would be confused if they tried it. I hope you'll bring this in at some point. Version numbers are just numbers, after all, and that's the point of semantic versioning. I would understand if you wanted to wait before doing so, but hope it's on your roadmap. |
|
Yes, I thought about the same fix years ago. Thanks for the PR. Let's leave it open for now, and we will merge it when 2.0 is on the line. |
|
Opened new PR: #465 |
Breaking Changes
Schema.Builderneeds to return the subclassed builder instance rather thanBuilder<S>in order to allow for fluency while building schemas. See related issue.Note: I also renamed
ConstSchema.ConstSchemaBuilderto justBuilderto match the other builders for consistency. I can pull this change back out if you don't want it. Since this PR is already a breaking change, I figured it made sense.