use linked hash maps where it matters#467
Open
JoshMcCullough wants to merge 1 commit intoeverit-org:masterfrom
Open
use linked hash maps where it matters#467JoshMcCullough wants to merge 1 commit intoeverit-org:masterfrom
JoshMcCullough wants to merge 1 commit intoeverit-org:masterfrom
Conversation
erosb
requested changes
Aug 18, 2022
Contributor
erosb
left a comment
erosb
left a comment
There was a problem hiding this comment.
Hello, using LinkedHashMap should be an optional feature which is disabled by default, due to possible performance degradation in some usecases (LinkedHashMap is slower than HashMap). So please make ordering toggle-able in SchemaLoaderBuilder, and instantiate HashMap / LinkedHashMap depending on the feature toggle during the schema loading process. For that you can start looking at ObjectSchemaLoader:59.
I think it is enough for now to implement order-keeping for "properties".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #395.