Fix extracting domain from url#210
Merged
lfarrel6 merged 2 commits intoevervault:masterfrom Feb 19, 2025
Merged
Conversation
It wasn't handling `.pathname` which is happening for us, and it seems node request supports And also noticed for the `Url` case it was returning `host` instead of `domain` so would be ignored 🙈
🦋 Changeset detectedLatest commit: e587299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tjenkinson
commented
Feb 19, 2025
lfarrel6
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug introduced in #206
It wasn't handling
.pathwhich is happening for us, and it seems node request supportsAnd also noticed for the
Urlcase it was returninghostinstead ofdomainso would be ignored 🙈