Open
Conversation
Fixed critical bug where getUTCMilliseconds() was incorrectly used instead of getTime(). getUTCMilliseconds() returns only the milliseconds component (0-999) of a date, not the full Unix timestamp. This caused the expiry validation to fail incorrectly when comparing timestamps. Changes: - Replace expiry.getUTCMilliseconds() with expiry.getTime() to get the full timestamp - Replace new Date().getUTCMilliseconds() with Date.now() for getting current timestamp 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added tests to cover the expiry validation logic that was fixed in the previous commit: - Validates expiry accepts Date objects within next 10 minutes - Validates expiry rejects past dates - Validates expiry rejects dates more than 10 minutes in future - Validates expiry accepts timestamp numbers within next 10 minutes - Validates expiry rejects past timestamps - Validates expiry rejects timestamps more than 10 minutes in future - Validates expiry rejects invalid types (e.g. strings) These tests ensure the bug fix works correctly and prevent regression. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed bug in the
createTokenfunction wheregetUTCMilliseconds()was incorrectly used instead ofgetTime().The Bug
getUTCMilliseconds()returns only the milliseconds component (0-999) of a date, not the full Unix timestamp. This caused the expiry validation to fail incorrectly when comparing timestamps.Changes
expiry.getUTCMilliseconds()withexpiry.getTime()to get the full timestamp (line 233)new Date().getUTCMilliseconds()withDate.now()for getting current timestamp (line 242)Impact
This bug would have caused the expiry validation to always fail since it was comparing millisecond values (0-999) instead of actual Unix timestamps. With this fix, the token expiry validation will work correctly.