Skip to content

fix: panic on Archive event due to unchecked type assertion - #125

Open
FlavioPulli wants to merge 1 commit into
evolution-foundation:mainfrom
FlavioPulli:fix/archive-event-panic
Open

fix: panic on Archive event due to unchecked type assertion#125
FlavioPulli wants to merge 1 commit into
evolution-foundation:mainfrom
FlavioPulli:fix/archive-event-panic

Conversation

@FlavioPulli

@FlavioPulli FlavioPulli commented Jul 24, 2026

Copy link
Copy Markdown

myEventHandler builds postMap without a "data" key, so the *events.Archive case asserting postMap["data"].(map[string]interface{}) (pkg/whatsmeow/service/whatsmeow.go:1820) panics the whole process whenever a chat is archived or unarchived on the paired phone.

Every other case that reads postMap["data"] guards the key first (Message, Receipt, etc.) — Archive was the only one missing the guard. This builds the data payload map directly, preserving the exact webhook shape.

How to reproduce: pair an instance, archive any chat on the phone → the process dies with panic: interface conversion: interface {} is nil, not map[string]interface {}.

Summary by Sourcery

Bug Fixes:

  • Fix crash on chat archive/unarchive events caused by unchecked type assertion on the webhook data payload.

myEventHandler builds postMap without a "data" key, so the Archive case
asserting postMap["data"].(map[string]interface{}) panics the whole
process whenever a chat is archived or unarchived on the paired phone.
Every other case that reads postMap["data"] guards the key first (e.g.
Message, Receipt); Archive was the only one missing it. Build the data
payload map directly, preserving the exact webhook shape.
@sourcery-ai

sourcery-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes a panic in Archive event handling by removing an unsafe type assertion on postMap["data"] and building the archive payload map directly, consistent with other event handlers.

Flow diagram for Archive event handling in myEventHandler

flowchart TD
    A[myEventHandler rawEvt] --> B[assert evt as *events.Archive]
    B --> C[set postMap event = Archive]
    C --> D[build data map directly]
    D -->|postMap data| E[send webhook payload]
    E --> F[LogInfo Chat archived]
Loading

File-Level Changes

Change Details Files
Make Archive event payload construction safe and consistent to prevent panics on chat (un)archive.
  • Remove unsafe type assertion on postMap["data"] in the Archive event handler case.
  • Construct the Archive webhook payload as a new map[string]interface{} literal with JID, Timestamp, Action, and FromFullSync fields.
  • Assign the newly constructed payload map directly to postMap["data"] instead of mutating a previously asserted map.
pkg/whatsmeow/service/whatsmeow.go

Possibly linked issues

  • #panic-archive-event-v0.7.1: PR fixes the unchecked Archive event data type assertion causing panics and container restarts in v0.7.1.
  • #Bug: API /chat/archive - interface conversion: interface {} is *events.Archive, not map[string]interface {} (v0.7.2): PR directly fixes the Archive event panic reported in the issue by safely building the data payload map.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant