Skip to content

fix: skip NATS connection when URL is empty #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joldmarfilho wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: skip NATS connection when URL is empty #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3c05b4
fix: skip NATS connection when URL is empty
Jul 26, 2026
1860110
test(nats): refactor tests and add global events state assertion
joldmarfilho Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/events/nats/nats_producer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
logger_wrapper "github.com/evolution-foundation/evolution-go/pkg/logger"
"github.com/gomessguii/logger"
"github.com/nats-io/nats.go"
"strings"
)

type natsProducer struct {
Expand All @@ -20,6 +21,15 @@ func NewNatsProducer(
natsGlobalEvents []string,
loggerWrapper *logger_wrapper.LoggerManager,
) producer_interfaces.Producer {
if strings.TrimSpace(url) == "" {
return &natsProducer{
conn: nil,
natsGlobalEnabled: false,
natsGlobalEvents: nil,
loggerWrapper: loggerWrapper,
}
}

conn, err := nats.Connect(url)
if err != nil {
logger.LogError("Failed to connect to NATS: %v", err)
Expand Down
31 changes: 31 additions & 0 deletions pkg/events/nats/nats_producer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package nats_producer

import "testing"

func TestNewNatsProducerDoesNotConnectWithoutURL(t *testing.T) {

@sourcery-ai sourcery-ai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Cover both empty and whitespace-only URLs, ideally via table-driven subtests

This test only covers the whitespace-only case (" "). Since the behavior should be the same for both empty and whitespace-only URLs, please either add a separate test for "" or convert this into a table-driven test with subtests for "" and " " (and any other relevant variants) to ensure we’re protected against regressions for all "empty" URL forms.

tests := []struct {
name string
url string
}{
{"Empty URL", ""},
{"Whitespace URL", " "},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
producer, ok := NewNatsProducer(tt.url, true, []string{"event1"}, nil).(*natsProducer)
if !ok {
t.Fatal("constructor returned an unexpected producer type")
}
if producer.conn != nil {
t.Fatal("NATS connection must stay nil when NATS_URL is empty")
}
if producer.natsGlobalEnabled {
t.Fatal("NATS global publishing must stay disabled without a URL")
}
if producer.natsGlobalEvents != nil {
t.Fatal("natsGlobalEvents must be nil when NATS_URL is empty")
}
})
}
}