[image_spec]: Add git to default apt packages for pip/uv git URL installs#14
Open
amanchoudhri wants to merge 1 commit intomasterfrom
Open
[image_spec]: Add git to default apt packages for pip/uv git URL installs#14amanchoudhri wants to merge 1 commit intomasterfrom
amanchoudhri wants to merge 1 commit intomasterfrom
Conversation
…nstalls Co-Authored-By: Aman Choudhri <amanchoudhri@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When building Docker images with
ImageSpec, if the requirements contain git-based dependencies (e.g.,git+https://github.com/...), the build fails becausegitis not installed in the basedebian:bookworm-slimimage. This causesuv pip syncorpip installto fail when trying to clone git repositories.Example error scenario: Running a Flyte workflow with requirements that include:
What changes were proposed in this pull request?
Always include
gitin the apt packages installed in the Docker image. This ensures pip/uv can install packages from git URLs without requiring users to manually addgitto theirapt_packageslist.Note: The
NIX_DOCKER_FILE_TEMPLATEalready includes git (line 170), so this brings the standard Docker template to parity.How was this patch tested?
Manual verification that the generated Dockerfile now includes
apt-get install git.Human Review Checklist
gitentries (if user also specifies it) could cause issues (apt-get handles this gracefully)Check all the applicable boxes
Link to Devin run: https://app.devin.ai/sessions/e921c20129a54329820035d836c303e5
Requested by: Aman Choudhri (aman@exa.ai) (@amanchoudhri)