fix(entrypoint): create dest_dir before download_distribution for nix containers#31
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
fix(entrypoint): create dest_dir before download_distribution for nix containers#31devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
… containers Co-Authored-By: Samuel Mitchell <sammiphone6@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Nix-built container images (
ImageSpec(nix=True)) produce minimal filesystem layouts that may not include/root. Thepyflyte registerCLI defaults--destination-dirto/root, which gets baked into the task template as--dest-dir /root. Whenpyflyte-fast-executeruns inside a nix container,download_distributionraises:because
/rootdoesn't exist in the container (nix images useWorkingDir=/service).Observed in production on:
flytesnacks/staging/ax9ttpbwtd6crjxdqdfzWhat changes were proposed in this pull request?
Add
os.makedirs(dest_dir, exist_ok=True)infast_execute_task_cmdbefore calling_download_distribution. This ensures the destination directory is created if it doesn't already exist, making the entrypoint resilient to minimal container filesystems.How was this patch tested?
Not yet tested with a unit test. The fix was validated by tracing the exact failure path from production Loki logs through the entrypoint code. The
exist_ok=Trueflag ensures no behavior change when the directory already exists (i.e., all non-nix containers).Check all the applicable boxes
Human Review Checklist
os.makedirswon't hit permission issues in restricted containers/rootcould mask a misconfigured--destination-dirLink to Devin run | Requested by @sammiphone6