Version 1 by alvagante · Pull Request #38 · example42/pabawi

alvagante · 2026-03-15T15:28:24Z

No description provided.

- Delete orphaned database schema files (audit-schema.sql, migrations.sql, rbac-schema.sql) - Rename initial migration to 000_initial_schema.sql for clarity - Update DatabaseService to load only numbered migrations instead of base schema files - Move all schema definitions to the migrations directory as single source of truth - Add documentation in copilot-instructions.md explaining migration-first approach - Create internal task documentation for database schema cleanup process - Eliminate duplicate table definitions that existed across base schemas and migrations

…a file - Update COPY instruction to include all database files and migrations - Change from copying only schema.sql to copying entire src/database/ directory - Ensures future database-related files are automatically included in builds - Improves maintainability by avoiding need to update Dockerfile when new database files are added

…tern - Add new Proxmox integration with ProxmoxClient, ProxmoxService, and ProxmoxIntegration classes - Implement Proxmox API client with authentication and resource management capabilities - Add comprehensive test coverage for Proxmox integration and service layer - Update IntegrationManager to register and manage Proxmox integration - Add dedicated Proxmox routes handler for API endpoints - Update integration types to include Proxmox configuration schema - Refactor ConfigService and schema to support Proxmox settings - Update server configuration to include Proxmox routes - Add Kiro specification files for puppet-pabawi refactoring workflow - Update vitest configuration for improved test execution - Improves infrastructure flexibility by adding virtualization platform support alongside existing integrations

…ycle management - Add ProvisionPage with dynamic form generation for VM and LXC creation - Add ManageTab component for node lifecycle actions (start, stop, reboot, destroy) - Add ProxmoxProvisionForm and ProxmoxSetupGuide components for integration setup - Add formGenerator utility for dynamic form rendering based on capability metadata - Add permissions system for RBAC-aware UI element visibility - Add comprehensive validation and error handling for provisioning operations - Add test utilities and generators for provisioning-related tests - Add documentation for Proxmox setup, provisioning, permissions, and management workflows - Add Kiro specification files for Proxmox frontend UI and integration features - Update Navigation component to include new Provision page route - Update IntegrationSetupPage to support Proxmox configuration - Update API client with provisioning endpoints and type definitions - Update package.json with required dependencies

- Move 7 completed task documents from .kiro/todo to .kiro/done directory - Add comprehensive REMAINING_TODOS_REPORT.md with prioritized task breakdown - Include test failure analysis, RBAC issues, and environment configuration items - Add SQLite test database temporary files (test-migration.db-shm, test-migration.db-wal) - Update frontend logger with minor improvements - Consolidate task tracking and provide clear roadmap for remaining work

- Add getNodes() method to retrieve PVE cluster nodes with status and resource info - Add getNextVMID() method to fetch next available VM ID from cluster - Add getISOImages() method to list ISO images available on node storage - Add getTemplates() method to list OS templates available on node storage - Implement caching for node and resource queries (60-120 second TTL) - Add corresponding integration layer methods to expose Proxmox service capabilities - Update frontend navigation and routing to support new provisioning workflows - Enhance ProxmoxProvisionForm with node selection and resource discovery UI - Update API client and type definitions for provisioning operations - Improve error handling and logging across Proxmox integration layer

- Update foundFilter initial state from 'all' to 'found' for better UX - Aligns with filterMode default behavior to show relevant data by default - Reduces noise by filtering out not-found entries on initial load

…ved API handling - Fix ProxmoxClient to use form-urlencoded encoding for POST/PUT/DELETE requests instead of JSON, matching Proxmox API requirements - Add detailed error messages in API responses by including response body text for better diagnostics - Add getStorages() method to ProxmoxService and ProxmoxIntegration to query available storage devices on nodes with optional content type filtering - Add getNetworkBridges() method to ProxmoxService and ProxmoxIntegration to query network interfaces on nodes with bridge type filtering - Implement caching for both storage and network queries with 120-second TTL to reduce API calls - Update ProxmoxProvisionForm frontend component to use new storage and network discovery endpoints - Extend provisioning types to support storage and network configuration options - Update API client to expose new storage and network discovery endpoints

… and code quality improvements Co-authored-by: alvagante <283804+alvagante@users.noreply.github.com>

- DatabaseAdapter interface with query, execute, transaction support - SQLiteAdapter: full implementation with WAL mode, foreign keys - PostgresAdapter: full implementation with pg pool, transaction client - AdapterFactory: creates correct adapter based on DB_TYPE env var - Error types: DatabaseQueryError, DatabaseConnectionError - Tests for all three components (39 tests passing)

backend/src/routes/inventory.ts

backend/test/database/SQLiteAdapter.test.ts

Copilot

Pull request overview

This PR introduces a database-adapter abstraction (SQLite + PostgreSQL), migrates services/tests to the new adapter API, and adds Proxmox integration endpoints/capabilities (including lifecycle actions and provisioning discovery), along with version bumps and Docker packaging updates.

Changes:

Replace direct sqlite3 usage with a new DatabaseAdapter interface, plus SQLiteAdapter and PostgresAdapter, updating services and tests accordingly.
Add Proxmox integration wiring (server registration, provisioning discovery endpoint, node lifecycle/destroy endpoints) and enhance inventory node linking to retain per-source identifiers.
Update build/Docker packaging to ship migration files (migration-first), add pg dependency, and bump version labels.

Reviewed changes

Copilot reviewed 87 out of 199 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
backend/test/integration/batch-execution.test.ts	Switch test DB usage to `SQLiteAdapter`/`DatabaseAdapter` helpers.
backend/test/integration/auth-flow.test.ts	Update direct SQL execution to new adapter `execute()`.
backend/test/database/rbac-schema.test.ts	Migrate schema verification tests to adapter `queryOne/execute`.
backend/test/database/migration-integration.test.ts	Replace sqlite callback wrappers with adapter `query/queryOne`.
backend/test/database/index-verification.test.ts	Use adapter queries for index/pragma validation checks.
backend/test/database/SQLiteAdapter.test.ts	Add test coverage for `SQLiteAdapter` lifecycle/query/transactions.
backend/test/database/PostgresAdapter.test.ts	Add basic instantiation/placeholder/init-failure tests for `PostgresAdapter`.
backend/test/database/MigrationRunner.test.ts	Update migration runner tests for adapter + dialect-specific migration selection.
backend/test/database/ExecutionRepository.test.ts	Replace sqlite3 DB with adapter-backed in-memory DB.
backend/test/database/AdapterFactory.test.ts	Add tests for adapter factory + new DB error types.
backend/test/UserService.test.ts	Migrate to adapter + adjust role assignment expectations (default Viewer role).
backend/test/UserService.password.test.ts	Migrate to adapter + seed Viewer role; execute schema via adapter.
backend/test/RoleService.test.ts	Migrate to adapter; execute schema statements via adapter.
backend/test/GroupService.test.ts	Migrate to adapter; simplify query helpers and schema init.
backend/src/services/UserService.ts	Replace sqlite3-specific DB helpers with `DatabaseAdapter` methods.
backend/src/services/SetupService.ts	Replace sqlite callbacks with adapter `queryOne/execute` + structured logging.
backend/src/services/RoleService.ts	Replace sqlite helpers with adapter `execute/query/queryOne`.
backend/src/services/PermissionService.ts	Replace sqlite helpers with adapter `execute/query/queryOne`.
backend/src/services/GroupService.ts	Replace sqlite helpers with adapter `execute/query/queryOne`.
backend/src/services/BatchExecutionService.ts	Replace sqlite callbacks with adapter calls; simplify DB actions.
backend/src/services/AuthenticationService.ts	Replace sqlite helpers with adapter calls for auth/lockout tables.
backend/src/services/AuditLoggingService.ts	Replace sqlite helpers with adapter calls; return `changes` via adapter execute.
backend/src/server.ts	Register Proxmox plugin when configured; add initialization logging.
backend/src/routes/streaming.ts	Allow EventSource auth via `token` query param -> Authorization header fallback.
backend/src/routes/inventory.ts	Add Proxmox node lifecycle and destroy endpoints.
backend/src/routes/integrations/status.ts	Add “proxmox not configured” status entry for UI.
backend/src/routes/integrations/provisioning.ts	New provisioning discovery endpoint for frontend integration listing.
backend/src/routes/integrations.ts	Mount Proxmox + provisioning routers with optional auth/RBAC.
backend/src/middleware/rbacMiddleware.ts	Switch middleware DB dependency to `DatabaseAdapter`.
backend/src/middleware/authMiddleware.ts	Switch middleware DB dependency to `DatabaseAdapter`.
backend/src/integrations/types.ts	Add `ProvisioningCapability` and parameter validation metadata.
backend/src/integrations/proxmox/types.ts	New Proxmox integration type definitions and error classes.
backend/src/integrations/proxmox/ProxmoxIntegration.ts	New Proxmox plugin implementing inventory + execution tool behaviors.
backend/src/integrations/NodeLinkingService.ts	Extend linked nodes to keep per-source IDs/URIs; adjust identifier extraction.
backend/src/integrations/IntegrationManager.ts	Return `LinkedNode[]` in aggregated inventory; add provisioning capability aggregation.
backend/src/database/rbac-schema.sql	Remove legacy RBAC schema file (migration-first).
backend/src/database/migrations/000_initial_schema.sql	Add header docs; align with migration-first approach.
backend/src/database/migrations.sql	Remove legacy monolithic migrations file (migration-first).
backend/src/database/errors.ts	New DB error classes for query/connection errors.
backend/src/database/audit-schema.sql	Remove legacy audit schema file (migration-first).
backend/src/database/SQLiteAdapter.ts	New sqlite-backed `DatabaseAdapter` implementation (WAL/FKs + query helpers).
backend/src/database/PostgresAdapter.ts	New pg-backed `DatabaseAdapter` implementation with tx support.
backend/src/database/MigrationRunner.ts	Switch to adapter; add dialect-specific migration file selection.
backend/src/database/ExecutionRepository.ts	Switch to adapter; remove sqlite callback wrappers.
backend/src/database/DatabaseService.ts	Use adapter factory; simplify init to “migrations only” approach.
backend/src/database/DatabaseAdapter.ts	New unified DB interface shared across services.
backend/src/database/AdapterFactory.ts	New factory selecting sqlite vs postgres based on env.
backend/src/config/schema.ts	Add Zod schema/types for Proxmox integration config.
backend/src/config/ConfigService.ts	Parse Proxmox env vars into integration config structure.
backend/package.json	Bump version, add `pg` deps, update build to copy migrations directory.
Dockerfile.ubuntu	Update image label version.
Dockerfile.alpine	Update image label version.
Dockerfile	Update image label version; copy full database dir into dist in container.
CLAUDE.md	Update docs to reflect migration-first DB schema approach.
.kiro/todo/proxmox-restart-required.md	Add operational note about restarting server to clear cached code.
.kiro/todo/expert-mode-prototype-pollution.md	Add security TODO note about prototype-pollution sanitization.
.kiro/todo/REMAINING_TODOS_REPORT.md	Add report summarizing remaining work/test failures.
.kiro/steering/security-best-practices.md	Add allowlist-secret guidance note.
.kiro/specs/pabawi-release-1-0-0/.config.kiro	Add spec config metadata for release work.
.kiro/specs/090/puppet-pabawi-refactoring/tasks.md	Add refactoring plan/tasks document.
.kiro/specs/090/puppet-pabawi-refactoring/requirements.md	Add requirements document for Puppet module refactor.
.kiro/specs/090/puppet-pabawi-refactoring/.config.kiro	Add spec config metadata for Puppet refactor.
.kiro/specs/090/proxmox-integration/.config.kiro	Add spec config metadata for Proxmox integration.
.kiro/specs/090/proxmox-frontend-ui/requirements.md	Add frontend requirements spec for provisioning UI.
.kiro/specs/090/proxmox-frontend-ui/.config.kiro	Add spec config metadata for frontend UI feature.
.kiro/done/proxmox-ssl-fix.md	Document completed Proxmox SSL fix.
.kiro/done/provisioning-endpoint-fix.md	Document completed provisioning endpoint addition.
.kiro/done/node-linking-redesign.md	Document completed node linking redesign.
.kiro/done/docker-missing-schema-files.md	Document completed Docker schema packaging fix.
.kiro/done/database-schema-cleanup-task.md	Document DB migration-first cleanup completion.
.kiro/database-cleanup-prompt.md	Add DB cleanup prompt/context document.
.github/copilot-instructions.md	Update DB schema docs to migration-first guidance.

backend/src/database/PostgresAdapter.ts

+    return "postgres";
+  }
+
+  getPlaceholder(index: number): string {


backend/src/database/PostgresAdapter.ts

+  async withTransaction<T>(fn: () => Promise<T>): Promise<T> {
+    if (!this._pool) {
+      throw new DatabaseQueryError(
+        "Database not connected",
+        "BEGIN TRANSACTION",
+        [],
+      );
+    }
+    const client = await this._pool.connect();
+    const previousClient = this._txClient;
+    this._txClient = client;
+    try {
+      await client.query("BEGIN");
+      const result = await fn();
+      await client.query("COMMIT");
+      return result;
+    } catch (error) {
+      await client.query("ROLLBACK");
+      throw error;
+    } finally {
+      client.release();
+      this._txClient = previousClient;
+    }
+  }


backend/src/database/SQLiteAdapter.ts

+            reject(
+              new DatabaseConnectionError(
+                `Failed to enable WAL mode: ${walErr.message}`,
+                this._databasePath,
+              ),
+            );
+            return;


backend/src/integrations/NodeLinkingService.ts

+        // Use the first node's name as the primary identifier
+        // (all related nodes should have the same name)
+        const primaryName = node.name;
+
+        // Create linked node with common name
+        const linkedNode: LinkedNode = {
+          id: primaryName, // Use name as primary ID for lookups
+          name: primaryName,
+          uri: node.uri, // Will be overwritten with combined URIs


backend/src/routes/inventory.ts

+        const result = await proxmoxTool.executeAction({
+          type: "task",
+          target: nodeId,
+          action: "destroy_vm",


backend/src/routes/inventory.ts

+   * Note: RBAC middleware should be applied at the route mounting level in server.ts
+   * Required permission: lifecycle:* or lifecycle:{action}
+   */
+  router.post(
+    "/:id/action",
+    asyncHandler(async (req: Request, res: Response): Promise<void> => {


backend/src/routes/streaming.ts

+        // Handle token from query parameter (EventSource doesn't support headers)
+        // Only move to Authorization header when no Authorization header is already present,
+        // then remove from query to reduce the chance of it being logged downstream.
+        if (
+          typeof req.query.token === "string" &&
+          !req.headers.authorization
+        ) {
+          req.headers.authorization = `Bearer ${req.query.token}`;
+          // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+          delete (req.query as Record<string, unknown>).token;
+        }
+


backend/src/routes/integrations/provisioning.ts

+        // Determine integration status based on health check
+        let status: 'connected' | 'degraded' | 'not_configured' = 'not_configured';
+        const healthCheck = proxmox.getLastHealthCheck();
+
+        if (healthCheck) {
+          if (healthCheck.healthy) {
+            status = 'connected';
+          } else if (healthCheck.message?.includes('not initialized') || healthCheck.message?.includes('disabled')) {
+            status = 'not_configured';
+          } else {
+            status = 'degraded';
+          }


Backend: - AWS plugin with EC2 inventory, provisioning, lifecycle, health check - Journal service with timeline aggregation and note support - Integration config service with AES-256-GCM encryption and merge - Proxmox VM/LXC compute type routing and separate create methods - API routes for journal, integration config, and AWS endpoints - ConfigService and schema updated for AWS env vars - Database migrations for journal_entries and integration_configs Frontend: - AWS provisioning form and setup guide - Proxmox VM and LXC provision forms (split from single form) - Journal timeline component with note form - Integration config management page - RBAC UI updated for new permission types - Navigation and routing updates Fixes: - Markdown table formatting in docs/integrations/aws.md - Allowlisted example AWS keys in AWSSetupGuide.svelte - Updated .secrets.baseline

Copilot

Pull request overview

Adds “Version 1” backend foundations for provisioning integrations (Proxmox + AWS), node linking improvements, and a migration-first, adapter-based database layer (SQLite/Postgres), with packaging updates for Docker builds.

Changes:

Introduces Proxmox and AWS provisioning integrations and related API routes (including provisioning discovery).
Refactors inventory node deduplication into a linking model with per-source node identity (sourceData), and updates aggregation types accordingly.
Reworks database access around a DatabaseAdapter abstraction, adds Postgres support, and moves schema fully into numbered migrations; updates Docker/build scripts to ship migrations.

Reviewed changes

Copilot reviewed 70 out of 239 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
backend/src/routes/integrations/provisioning.ts	New endpoint to discover provisioning integrations and capabilities.
backend/src/routes/integrations/aws.ts	New AWS integration API routes for inventory/provision/lifecycle/resource discovery.
backend/src/routes/integrations.ts	Mounts new Proxmox + provisioning routers; adds RBAC/auth gating.
backend/src/routes/integrationConfig.ts	New integration-config CRUD routes, using auth/RBAC.
backend/src/middleware/rbacMiddleware.ts	Switches RBAC middleware DB type to `DatabaseAdapter`.
backend/src/middleware/authMiddleware.ts	Switches auth middleware DB type to `DatabaseAdapter`.
backend/src/integrations/types.ts	Adds `ProvisioningCapability` and capability parameter validation metadata.
backend/src/integrations/proxmox/types.ts	Adds Proxmox integration types + error classes.
backend/src/integrations/proxmox/ProxmoxIntegration.ts	New Proxmox plugin implementation (inventory/actions/provisioning/journal).
backend/src/integrations/proxmox/ProxmoxClient.ts	New Proxmox API client with retries and task polling.
backend/src/integrations/aws/types.ts	Adds AWS integration types + `AWSAuthenticationError`.
backend/src/integrations/aws/tests/AWSPlugin.healthCheck.test.ts	Adds health check unit tests for AWS plugin.
backend/src/integrations/aws/AWSPlugin.ts	New AWS plugin implementation (inventory/actions/provisioning/journal).
backend/src/integrations/NodeLinkingService.ts	Extends linked nodes with per-source identity (`sourceData`) and alters linking behavior.
backend/src/integrations/IntegrationManager.ts	Inventory now returns `LinkedNode[]`; adds provisioning capability aggregation.
backend/src/database/rbac-schema.sql	Removes legacy RBAC schema file (migration-first).
backend/src/database/audit-schema.sql	Removes legacy audit schema file (migration-first).
backend/src/database/migrations.sql	Removes legacy aggregated migrations file (migration-first).
backend/src/database/migrations/000_initial_schema.sql	Documents initial schema migration (header).
backend/src/database/migrations/007_permissions_and_provisioner_role.sql	Seeds new permissions/roles for provisioning/journal/config resources.
backend/src/database/migrations/008_journal_entries.sql	Adds `journal_entries` table migration.
backend/src/database/migrations/009_integration_configs.sql	Adds per-user `integration_configs` table migration.
backend/src/database/errors.ts	Adds typed DB error classes for adapters.
backend/src/database/DatabaseAdapter.ts	Introduces unified DB adapter interface.
backend/src/database/AdapterFactory.ts	Adds adapter factory controlled by `DB_TYPE` / `DATABASE_URL`.
backend/src/database/SQLiteAdapter.ts	Implements `DatabaseAdapter` using `sqlite3`.
backend/src/database/PostgresAdapter.ts	Implements `DatabaseAdapter` using `pg`.
backend/src/database/MigrationRunner.ts	Refactors migration runner to use `DatabaseAdapter` + dialect-specific migration selection.
backend/src/database/ExecutionRepository.ts	Refactors repository to use `DatabaseAdapter` (still sqlite-style SQL).
backend/src/database/DatabaseService.ts	Refactors service to create/init adapter and run migrations only.
backend/src/config/schema.ts	Adds config schemas for Proxmox + AWS integrations.
backend/src/config/ConfigService.ts	Parses Proxmox/AWS config from env; adds `getAWSConfig()`.
backend/package.json	Adds AWS SDK + pg deps; updates build to ship migrations directory.
Dockerfile	Copies full DB directory into image; bumps version label.
Dockerfile.alpine	Bumps version label.
Dockerfile.ubuntu	Bumps version label.
CLAUDE.md	Updates docs to reflect migration-first DB approach.
.pre-commit-config.yaml	Tightens duplicate/backup filename detection regex.
.kiro/todo/proxmox-restart-required.md	Adds operational note about restarting backend to pick up changes.
.kiro/todo/expert-mode-prototype-pollution.md	Adds security TODO doc for prototype pollution risk.
.kiro/todo/REMAINING_TODOS_REPORT.md	Adds TODO status report.
.kiro/steering/security-best-practices.md	Updates security steering doc with allowlist-secret guidance.
.kiro/specs/pabawi-release-1-0-0/.config.kiro	Adds spec config metadata.
.kiro/specs/090/puppet-pabawi-refactoring/tasks.md	Adds implementation plan for puppet module refactoring.
.kiro/specs/090/puppet-pabawi-refactoring/requirements.md	Adds requirements for puppet module refactoring.
.kiro/specs/090/puppet-pabawi-refactoring/.config.kiro	Adds spec config metadata.
.kiro/specs/090/proxmox-integration/requirements.md	Adds Proxmox integration requirements spec.
.kiro/specs/090/proxmox-integration/.config.kiro	Adds spec config metadata.
.kiro/specs/090/proxmox-frontend-ui/tasks.md	Adds frontend UI implementation plan spec.
.kiro/specs/090/proxmox-frontend-ui/requirements.md	Adds frontend UI requirements spec.
.kiro/specs/090/proxmox-frontend-ui/.config.kiro	Adds spec config metadata.
.kiro/done/proxmox-ssl-fix.md	Adds “done” note about Proxmox SSL handling approach.
.kiro/done/provisioning-endpoint-fix.md	Adds “done” note about provisioning endpoint addition.
.kiro/done/node-linking-redesign.md	Adds “done” note about node linking redesign.
.kiro/done/docker-missing-schema-files.md	Adds “done” note about Docker copying DB artifacts.
.kiro/done/database-schema-cleanup-task.md	Adds “done” note about migration-first DB cleanup.
.kiro/database-cleanup-prompt.md	Adds internal prompt doc for DB cleanup work.
.github/copilot-instructions.md	Updates repo instructions to reflect migration-first DB approach.

backend/src/database/MigrationRunner.ts

  private async recordMigration(migration: MigrationFile): Promise<void> {
    const now = new Date().toISOString();
-
-    return new Promise((resolve, reject) => {
-      this.db.run(
-        "INSERT INTO migrations (id, name, appliedAt) VALUES (?, ?, ?)",
-        [migration.id, migration.filename, now],
-        (err) => {
-          if (err) {
-            reject(new Error(`Failed to record migration: ${err.message}`));
-          } else {
-            resolve();
-          }
-        }
-      );
-    });
+    await this.db.execute(
+      "INSERT INTO migrations (id, name, appliedAt) VALUES (?, ?, ?)",
+      [migration.id, migration.filename, now]
+    );


backend/src/database/DatabaseService.ts

+      // Ensure database directory exists (for SQLite)
      const dbDir = dirname(this.databasePath);
      if (!existsSync(dbDir)) {
        mkdirSync(dbDir, { recursive: true });
      }


backend/src/integrations/aws/AWSPlugin.ts

+    this.ensureInitialized();
+
+    const startedAt = new Date().toISOString();
+    const target = Array.isArray(action.target) ? action.target[0] : action.target;


backend/src/integrations/aws/AWSPlugin.ts

+    return {
+      id: `aws-provision-${Date.now()}`,
+      type: "task",
+      targetNodes: [target],


backend/src/integrations/aws/AWSPlugin.ts

+        {
+          nodeId: instanceId,


backend/src/integrations/NodeLinkingService.ts

+        const linkedNode: LinkedNode = {
+          id: primaryName, // Use name as primary ID for lookups
+          name: primaryName,


backend/src/routes/integrations.ts

+  if (db) {
+    const authMiddleware = createAuthMiddleware(db, jwtSecret);
+    const rbacMiddleware = createRbacMiddleware(db);
+
+    router.use(
+      "/provisioning",
+      asyncHandler(authMiddleware),
+      asyncHandler(rbacMiddleware('provisioning', 'read')),
+      createProvisioningRouter(integrationManager)
+    );
+  } else {
+    // Fallback for cases where database is not available (e.g., tests)
+    router.use("/provisioning", createProvisioningRouter(integrationManager));
+  }


backend/src/routes/integrationConfig.ts

+  const configService = new IntegrationConfigService(
+    databaseService.getConnection(),
+    process.env.JWT_SECRET ?? "",
+  );
+  const authMiddleware = createAuthMiddleware(databaseService.getConnection());


backend/src/integrations/proxmox/ProxmoxClient.ts

+    // for ALL HTTPS traffic, not just Proxmox. Instead, log a warning to guide the operator.
+    // Per-client TLS bypass via a custom HTTPS agent/dispatcher is the correct solution.
+    if (config.ssl && config.ssl.rejectUnauthorized === false) {
+      this.logger.warn(
+        "Proxmox ssl.rejectUnauthorized=false is set, but per-client TLS bypass is not yet implemented. " +
+        "Proxmox connections will use the default TLS verification. " +
+        "Configure a trusted CA certificate (ssl.ca) to connect to Proxmox with self-signed certs.",
+        {
+          component: "ProxmoxClient",
+          operation: "constructor",
+        }
+      );


backend/src/routes/integrations/aws.ts

+import { z } from "zod";
+import { ZodError } from "zod";


alvagante and others added 11 commits March 11, 2026 18:14

fix(NodeHieraTab): change default foundFilter state to 'found'

a65697e

- Update foundFilter initial state from 'all' to 'found' for better UX - Aligns with filterMode default behavior to show relevant data by default - Reduces noise by filtering out not-found entries on initial load

fix: apply review feedback - API safety, accessibility, type cleanup,…

e4e2335

… and code quality improvements Co-authored-by: alvagante <283804+alvagante@users.noreply.github.com>

feat: Database abstraction

a05916f

Copilot AI review requested due to automatic review settings March 15, 2026 15:28

github-code-quality bot found potential problems Mar 15, 2026

View reviewed changes

backend/src/routes/inventory.ts Fixed Show fixed Hide fixed

backend/src/routes/inventory.ts Fixed Show fixed Hide fixed

backend/test/database/SQLiteAdapter.test.ts Fixed Show fixed Hide fixed

Copilot AI reviewed Mar 15, 2026

View reviewed changes

alvagante added 2 commits March 15, 2026 16:59

test: Tests and fixes

170fcf0

Copilot AI review requested due to automatic review settings March 16, 2026 11:33

Copilot AI reviewed Mar 16, 2026

View reviewed changes

feat: Aws and multi source facts

995aa8d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 1#38

Version 1#38
alvagante wants to merge 14 commits intomainfrom
0100

alvagante commented Mar 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alvagante commented Mar 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants