Skip to content

Fix ssl_cert/ssl_key/ssl_ca examples to use file paths instead of file:// URIs#4

Merged
alvagante merged 2 commits intotestfrom
copilot/sub-pr-1-another-one
Feb 23, 2026
Merged

Fix ssl_cert/ssl_key/ssl_ca examples to use file paths instead of file:// URIs#4
alvagante merged 2 commits intotestfrom
copilot/sub-pr-1-another-one

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

The ssl_cert, ssl_key, and ssl_ca parameters in data/common.yaml were documented with file:// URIs, but these params expect plain filesystem paths written directly into .env. The *_source params are the correct ones for URI values.

Changes

  • data/common.yaml: Replace file:///etc/... URI examples with plain paths for ssl_cert, ssl_key, ssl_ca in both the PuppetDB and Puppet Server integration sections

Before:

# pabawi::integrations::puppetdb::ssl_cert: 'file:///etc/puppetlabs/puppet/ssl/certs/agent.pem'
# pabawi::integrations::puppetdb::ssl_key: 'file:///etc/puppetlabs/puppet/ssl/private_keys/agent.pem'
# pabawi::integrations::puppetdb::ssl_ca:  'file:///etc/puppetlabs/puppet/ssl/certs/ca.pem'

After:

# pabawi::integrations::puppetdb::ssl_cert: '/etc/puppetlabs/puppet/ssl/certs/agent.pem'
# pabawi::integrations::puppetdb::ssl_key: '/etc/puppetlabs/puppet/ssl/private_keys/agent.pem'
# pabawi::integrations::puppetdb::ssl_ca:  '/etc/puppetlabs/puppet/ssl/certs/ca.pem'

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…y/ssl_ca examples

Co-authored-by: alvagante <283804+alvagante@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback from review on 'Test' pull request Fix ssl_cert/ssl_key/ssl_ca examples to use file paths instead of file:// URIs Feb 23, 2026
Copilot AI requested a review from alvagante February 23, 2026 07:43
@alvagante alvagante marked this pull request as ready for review February 23, 2026 07:55
Copilot AI review requested due to automatic review settings February 23, 2026 07:55
@alvagante alvagante merged commit 2353370 into test Feb 23, 2026
2 of 3 checks passed
@alvagante alvagante deleted the copilot/sub-pr-1-another-one branch February 23, 2026 07:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects the documentation examples in data/common.yaml for SSL certificate configuration. The examples were incorrectly showing file:// URI notation for the ssl_cert, ssl_key, and ssl_ca parameters, when these parameters expect plain filesystem paths. The file:// URI format is only appropriate for the corresponding *_source parameters, which handle file copying/downloading operations.

Changes:

  • Updated PuppetDB integration SSL parameter examples to use plain paths instead of file:// URIs
  • Updated Puppet Server integration SSL parameter examples to use plain paths instead of file:// URIs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants