Conversation
Merged
…y/ssl_ca examples Co-authored-by: alvagante <283804+alvagante@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback from review on 'Test' pull request
Fix ssl_cert/ssl_key/ssl_ca examples to use file paths instead of file:// URIs
Feb 23, 2026
alvagante
approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request corrects the documentation examples in data/common.yaml for SSL certificate configuration. The examples were incorrectly showing file:// URI notation for the ssl_cert, ssl_key, and ssl_ca parameters, when these parameters expect plain filesystem paths. The file:// URI format is only appropriate for the corresponding *_source parameters, which handle file copying/downloading operations.
Changes:
- Updated PuppetDB integration SSL parameter examples to use plain paths instead of
file://URIs - Updated Puppet Server integration SSL parameter examples to use plain paths instead of
file://URIs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ssl_cert,ssl_key, andssl_caparameters indata/common.yamlwere documented withfile://URIs, but these params expect plain filesystem paths written directly into.env. The*_sourceparams are the correct ones for URI values.Changes
data/common.yaml: Replacefile:///etc/...URI examples with plain paths forssl_cert,ssl_key,ssl_cain both the PuppetDB and Puppet Server integration sectionsBefore:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.